• R/O
  • HTTP
  • SSH

external-llvm: Commit


Commit MetaInfo

Revisionb36b39f7683b5e93fa2811bd0a9404676853f194 (tree)
Time2019-12-29 23:05:42
AuthorMauro Rossi <issor.oruam@gmai...>
CommiterChih-Wei Huang

Log Message

android: add 'Restat: true' to tblgenRule definition (llvm90)

Based on suggestion by Colin Cross, to avoid unnecessary rebuild of llvm90
in case of *.inc generated sources older than llvm90-tblgen binary.

When llvm90-tblgen binary is compiled and for some reason the build is interrupted,
the generated *.inc files will have a timestamp older than llvm90-tblgen binary,
at this point all libLLVM* targets depending on the *.inc files are always rebuilt.

'NINJA_ARGS="-d explain" make iso_img' command revealed the cause of the problem:

ninja explain: output out/soong/.intermediates/external/llvm90/llvm90-gen-attributes/gen/llvm/IR/
older than most recent input out/soong/host/linux-x86/bin/llvm90-tblgen (1570914978 vs 1575285173)
ninja explain: out/soong/.intermediates/external/llvm90/llvm90-gen-attributes/gen/llvm/IR/ is dirty

Signed-off-by: Mauro Rossi <>

Change Summary

Incremental Difference

--- a/soong/tblgen.go
+++ b/soong/tblgen.go
@@ -39,6 +39,7 @@ var (
3939 Command: "${llvm90Tblgen} ${includes} ${generator} -d ${depfile} -o ${out} ${in}",
4040 CommandDeps: []string{"${llvm90Tblgen}"},
4141 Description: "LLVM90 TableGen $in => $out",
42+ Restat: true,
4243 }, "includes", "depfile", "generator")
4344 )
Show on old repository browser