asume

Fork

#doAdd refactoring due to a focus (selection) bug - similar to bug at rev. 417 - when creating new node sometimes the selected line did not change to the new node at the tree. A ASMenuEditorTests refactorings.

#doAdd refactoring to refelect the treeToEdit removal - refactoring the tests to fit the changes. ASMenuTree>>questionForSavingChanges is now simplier

Refactorings: refactor cancel button to incorporate the treeToEdit change; added ASMenuEditor>>hierarchicalItemAsArray: for model to receive a hierarchicalItem Array size one (adjusted the tests for it)

#doRemove refactorings due to the treeToEdit instance variable dissapearence - code has been simplified and tests fixed

Refactoring tests ASMenuTreeTests>>setUp and ASMenuEditorTests at category treeSubCanvasTests

Fixing all tests in the protocol selectionChangeTests (ASMenuEditorTests) - discovered a regression at ASMenuEditor>>copyChildrenFromParent:into: which was fixed

Fixing all transformation tests in protocol transformationTests.

Refactoring node transformation to exclude treeToEdit instance variable, and update selectedMenuItem, simplified the transformation methods and fixed one testcase #testMultipleTransformationsOfSubtreeInToDataItem

Initial commit for removeing treeToEdit instance variable - to remove duplicity functionality.

Merge with Moving-in or -out multiple nodes

Refactored tests that failed beause the #doMoveIn and #doMoveOut do not change the its values children but only its own children (the Hierarchy is updated only on Lists - the values children are ignored)

Refactoring of #save method which now uses #convertHierarchicalListToASMenuTree a move to remove the instance variable treeToEdit (using this variable results in duplicate code when moving nodes around)

Do GUI refresh at #doDown and #doUp only after all changes are done -> speedup

#doMoveIn and #doMoveOut are now updating only the list (hierarchical list). It is ignoring the ASTree children as this is a duplicate funcitonality anyways. Have to refactor the rest of the application.

Initial commit for #doMoveOut

The #doMoveIn (moving from parent to child) is now complete. Created #canProceed: which will be used by all moving functionality - simplifies the code. Removed the functionality which moved when above a selection was a tree (caused too many problems and user can now mass move via up/down). Removed also 2 tests connected to this functionality.

Initial commit to a new branch. It will fix an issue with multiple lines being moved-in or -out from a subtree. Currently work in progress for #doMoveIn.

Added tag 0.4.0 for changeset 26a820fd1a23 and version bump

Merge with development

Merge with Moving multiple nodes

#doIndicatorClick fixes a bug with #doDown while user selects and then clicks on an indicator. Now movement with opened trees via indicator is done correctly. Testing #doDown movement with expanded subtrees.

Moving an expanded tree in a subtree to the end of the subtree does not close the moved expanded tree when #doDown is pressed more than needed. Adjusted the #testNodeMoveDownMultipleNodesInSubtree for it.

#doDown - moving down in the root tree does not collapse the last expanded tree (in the subTree it does); refactor tests for moving down multiple lines; created #doIndicatorClick to implement what happends when you click on the indicator.

Refactor #doDown to simplify it (created new #belowSelectedNode: method), created a test in which multiple lies are moved at the root tree #testNodeMoveDownMultipleNodes; refactor out the listHolder value in favour of an accessor (done in the whole treeNodeMoveTests group)

Refactor #doDown to support multiple nodes movement - correctly recognizes the end and does not move behind it.

Adding tests for moving up multiple lines via #doUp

#doUp refactoring - keep the above tree expanded (don't collapse it do to the move)

#doUp refactorings - improving code; splitting it into smaller pieces; improving readability; improved warning handling

Fixing the unexpected Salamander numbering 4.0 (without the last 0) - ASInformation>>extractNumericPart:. Adjusted tests to properly test this new reality. Code style refactorings

Refactore #doUp - simplified view notification (#childrenOrderChanged) and fixing moving within treeToEdit subtree. Simplified ASMenuTree>>doDoubleClick. Fixed failing test which tested root being unmovable.