Document what 'disabled' means in an enabler
Document what the disabled field in an action enabler is for.
I'm not sure if the text added here is correct or wrong, but based on it I assumed enabler.disabled to act like .ruledit_disabled for other structs. It does not, but also ruleset loading (both ruleset.c and rscompat.c) may set it in addition to ruledit.
Are these ruleset loading time disabled enablers still used at game run time? (the comment added here claims that only rulesave cares about 'disabled'). For the other 'ruledit_disabled' the logic is that they are ever set only inside ruledit - never when actually running the game, and thus we don't need to check against it at game run time (standard iterations do not).
Reply To cazfi
Ruleset loading will only set it in compatibility mode and when purging(/cleaning) unused entities, so it should be ruledit and freeciv-ruleup only. That is unless someone added support for playing rulesets from the previous version to the server while I didn't pay attention.
Are these ruleset loading time disabled enablers still used at game run time?
I could add a step that deletes them if you have plans to add ruleset compatibility and/or purging support to the server.