Ticket #42029

Disable PF_WAIT_DEBUG by default

Open Date: 2021-04-19 22:06 Last Update: 2021-04-22 19:43

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Assert enabled by PF_WAIT_DEBUG, added since 3.0.0-beta1 and 2.6.4, is currently failing a lot ( -> #41940). While it seems to be finding a genuine error, that error does not seem like a regression. So if there's any regression, it's that the existing error has now been turned more serious with an assert. More importantly, the assert might be overzealous with some rulesets even when the actual bug gets fixed. Things may change during the turn so that unit_move_rate(punit) is currently smaller than at the beginning of turn when moves_left was set. Similar for other variables asserted.

I propose disabling PF_WAIT_DEBUG by default.

Ticket History (3/4 Histories)

2021-04-19 22:06 Updated by: cazfi
  • New Ticket "Disable PF_WAIT_DEBUG by default" created
2021-04-19 22:12 Updated by: cazfi
  • Resolution Update from None to Accepted
2021-04-22 19:43 Updated by: cazfi
  • Status Update from Open to Closed
  • Owner Update from (None) to cazfi
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login