Ticket #42211

S3_0 alien Grassland has inconsistent mining_result & mining_time

Open Date: 2021-05-10 21:36 Last Update: 2021-05-16 11:52

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

S3_1 CI ruleup test for alien is failing, because S3_0 alien to upgrade from has mining_result = "no", but mining_time = 10 for Grassland. S3_1 now has a sanity check against that.

That's not hard error in S3_0 (the mining_time gets ignored when mining_result is "no"), and S3_0 is in semi-freeze before beta2 release. Still, maybe we consider fixing CI important enough to push in the fix now?

Ticket History (3/7 Histories)

2021-05-10 21:36 Updated by: cazfi
  • New Ticket "S3_0 alien Grassland has inconsistent mining_result & mining_time" created
2021-05-10 21:45 Updated by: cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 2.6.5 (closed)
2021-05-10 21:48 Updated by: cazfi
Comment

Maybe S3_1 should convert _time to zero in this kind of situations?

2021-05-10 22:06 Updated by: cazfi
  • Component Update from Rulesets to General
Comment

Now one patch for S3_0/S2_6, to fix the ruleset, and another for S3_1, to convert from inconsistent S3_0 ruleset, attached. Going to push S3_1 one immediately as a CI fix. S3_0/S2_6 patch will wait until after 3.0.0-beta2 is out.

2021-05-16 11:52 Updated by: cazfi
  • Status Update from Open to Closed
  • Owner Update from (None) to cazfi
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login