Messages tab now highlights red to start
Apologies if I'm describing an intended change. On gtk3 client, the Messages and Research tabs would have their text show up in blue, which would turn to red if you advanced to the next turn without reading them. In gtk3.22 they're starting red for me, on Mac OS X.
Did you open those tabs yourself, or did they open up automatically? If latter, it was triggered by some event that require your attention, and thus the red color is what is expected.
Had it open already. Here's a 10s video showing it happening:
Specifically at second 7 I have it open, I've read it, and then I hit for a new turn, and new messages turn it red
There *are* new messages in it, appeared during the turn change. Your idea that it should turn red only when it's too late to read messages after they are *removed* makes no sense to me.
Sorry, I have garbled what should be pretty simple. In both videos the Messages tab is already open, and recieves new messages in a new turn.
2.6.4 gtk3.22: https://imgur.com/a/W6QXRXq -- turns red
2.6.3 gtk3: https://imgur.com/a/CS9qCf3 -- turns blue
Is the change in behaviour intentional?
So the change is in that gtk3.22-client seems to have just one notify/alert color while gtk3-client had two, depending on the situation. I don't know if that's been intentional, but I'll look in to improving it in general (probably won't end up with the same setup as what gtk3-client had)
There will be a new version of this patch.
New versions of the patches
- Avoid duplicate calls to gtk_widget_get_style_context()
- Remove possible 'notice' color when 'alert' added