freeciv-client-rc-* should have default .autoaccept_tileset_suggestion = TRUE

• Reporter: alain_bkr
• Owner: (None)
• Type: Bugs
• Status: Open
• Component: Client common
• MileStone: (None)
• Priority: 5 - Medium
• Severity: 6
• Resolution: None
• File: 1

Details Reply

The default at least since 2.6 is .autoaccept_tileset_suggestion = FALSE. This should be set to TRUE , and also fixed on-the-fly when creating freeciv-client-rc-3.x from a previous version.

A harder fix, is just remove the option, and always load something compatible, even if sometimes this implies loading another tileset, which takes time.

---

Wrong topology of tileset is the root cause of many problems :

• distorted map (like europe 1900 which needs top view == trident )
• impossibility to move to a seemingly adjacent tile
• jumps over a tile
• weird pathes,
• ... and a very bad feeling for the player

If later the player want to change the tileset, it should be allowed only to choose amongst compatible ones (#42347 , https://www.hostedredmine.com/issues/685235 ),

I guess only developper would want to put an incompatible tileset.

https://www.hostedredmine.com/projects/freeciv/wiki/26tilesets ask the question

2.6 user upgrades to 3.0; upstream we have changed default priorities, added new tilesets, etc Keep their per-topo preferences?

• yes , Keep they per topology preference
• and set .autoaccept_tileset_suggestion = TRUE in freeciv-client-rc-3.x
• and do something in QT-client to propose only the compatible tilesets like in gtk , or clearly indicate the the gameplay can be completely broken

Problems occurs quickly when one load a scenario

scenarios (S3_0)$ zgrep topology *.gz 

europe_1900_WWI.sav.gz:"topology","",""                   #   flat map (no wrap) , real square tiles : was overhead in 2.6  
earth-large.sav.gz:"topology","WRAPX","WRAPX"             #  torus map ! 
earth-small.sav.gz:"topology","WRAPX","WRAPX"

british-isles.sav.gz:"topology","","WRAPX|ISO|HEX"        # normal map ,  iso-hex  == flat hex with horizontal  sides on top and bottom    (while 'hex' is thin with vertical sides :-(    )
europe.sav.gz:"topology","","WRAPX|ISO|HEX"
france.sav.gz:"topology","","WRAPX|ISO|HEX"
iberian-peninsula.sav.gz:"topology","","WRAPX|ISO|HEX"
italy.sav.gz:"topology","","WRAPX|ISO|HEX"
japan.sav.gz:"topology","","WRAPX|ISO|HEX"
north_america.sav.gz:"topology","","WRAPX|ISO|HEX"
tutorial.sav.gz:"topology","WRAPX|ISO|HEX","WRAPX|ISO|HEX"
hagworld.sav.gz:"topology","WRAPX","WRAPX|ISO|HEX"

Ticket History (3/7 Histories)

2021-05-23 08:07 Updated by: alain_bkr

• New Ticket "freeciv-client-rc-* should have default .autoaccept_tileset_suggestion = TRUE" created

2021-05-23 08:10 Updated by: alain_bkr

• Details Updated

2021-05-30 23:20 Updated by: alain_bkr

• File 0001-Default-client-options-to-accept-suggested-tileset.patch (File ID: 6958) is attached

2021-06-02 23:07 Updated by: cazfi

Comment Reply

Ruleset's tileset suggestion very rarely has anything to do with the topology. After all the same ruleset can be used with different topologies. I don't like the idea of overriding user's choice of tileset by default. User may very well know that his/her tileset is compatible with the ruleset (and better) despite not being exactly the one that ruleset suggests. For example I have multiple variant2 compatible tilesets (though only one published to wider audience). Variant2 suggests the published one. I very much prefer the dialog that allows me to keep the one I want to use instead of forcibly switching to that "standard" one.

I didn't know that Qt-client still does not implement tileset suggestion dialog (and probably then not soundset or musicset suggestion dialogs either). That should definitely be fixed -> new ticket.

2021-06-25 11:44 Updated by: cazfi

• Milestone Update from 2.6.5 (closed) to 2.6.6 (closed)

2021-12-10 08:06 Updated by: cazfi

• Milestone Update from 2.6.6 (closed) to (None)

2022-08-22 04:11 Updated by: cazfi

Comment Reply

Reply To cazfi

I didn't know that Qt-client still does not implement tileset suggestion dialog (and probably then not soundset or musicset suggestion dialogs either). That should definitely be fixed -> new ticket.

Except that it does.