Units on Rally-point GOTO don't show 'G' icon for goto status
lexxie9952 lexxie9952 Fixed here: https://github.com/Lexxie9952/fcw.org-server/commit/329cba20b8a214a502e677de29a57cbe19ab7950
Adding dest_tile to rally points and rally packets fixes this AND lets clients know and report the city's rally point. Note: there is a FIXME comment in there for servers who don't want to add the dest_tile field. In there is a previous and working hacky-patch that fixes some issues without adding the dest_tile. However, that means they can't set the punit->goto_tile correctly though, which will surely make issues. The commit as it currently stands, resolves all issues.
Feel free to cherry pick. If alternate solution implemented please notify me. Thanks
NOTE: Changes network protocol but not savegame compat.
I haven't investigated closely, but noticed that 'G' shows all right when rally point is used. I don't think it's deducted from goto_tile, anyway.
Reply To cazfi
I haven't investigated closely, but noticed that 'G' shows all right when rally point is used. I don't think it's deducted from goto_tile, anyway.
Which client?
I don't know about "not deducted from goto_tile, anyway".
Perhaps FCW clients figure out when to show a GOTO differently.
I don't understand how a client is supposed to represent things properly represent a unit going to a rally point if it has no way of knowing the destination.
Reply To cazfi
I don't think it's deducted from goto_tile, anyway.
This has no handling different from other activity icons; comes from unit's ACTIVITY_GOTO activity.
Can't reproduce failure to set goto_tile, either, when the actual goto starts.
When a unit is sent on GOTO because of a city rally point, if the GOTO dest_tile is more than one turn away, the unit will not show in the client with a 'G' to indicate it is still under an active not-yet-completed GOTO order.
Brief investigation of the issue discovered that the separate goto_tile field is not being set when a unit begins executing the movement of its rally point order.