Ticket #42968

Quickfix for a bug that sometimes trade partner is not revealed when route established

Open Date: 2021-10-02 20:56 Last Update: 2021-10-13 13:52

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

Related to #42967, and what was written there:

"The problem I'm debugging is that establishing foreign trade route should reveal the source city to the owner of the destination city. In the failing case owner of the destination city has before seen the tile where the source city is later established. send_city_info_at_tile() behavior causes the city not to get revealed. This then lead to client crash when trade partner was NULL there."

Overall the updates about trade partner are buggy (when trading with someone you who doesn't give you shared vision), and are likely to require lot of fixing. Meanwhile we should at least avoid the crashing cases -> quick fix in this ticket.

Ticket History (3/6 Histories)

2021-10-02 20:56 Updated by: cazfi
  • New Ticket "Quickfix for a bug that sometimes trade partner is not revealed when route established" created
2021-10-02 21:14 Updated by: cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 2.6.6 (closed)
2021-10-02 21:30 Updated by: cazfi
Comment

Additional client side fix -> #42969

2021-10-13 13:52 Updated by: cazfi
  • Status Update from Open to Closed
  • Owner Update from (None) to cazfi
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login