wrong help text shown
ddeanbrown Skipping technical explanation why it is so, I just say that "territory claiming base" = "ownable base". The code in question seems correct to me, but could use a comment clarifying it -> I assume this ticket will be resolved by adding such a comment.
ddeanbrown Adding a screen shot to show what the message looks like in context, where it doesn't make sense. I now think the problem is that it needs to be re-worded to say "Units of a nation at war with the nation that currently owns it can be captured by such units."
Reply To ddeanbrown
Adding a screen shot to show what the message looks like in context, where it doesn't make sense. I now think the problem is that it needs to be re-worded to say "Units of a nation at war with the nation that currently owns it can be captured by such units."
Negative. It's the base itself that gets captured (so it starts to claim terrain for the new owner)
ddeanbrown Ah - now I understand. Not sure if it's my stupidity or maybe the message needs to be clearer - "Base can be captured..."
Later branches have this part of code reworked. One thing we could backport is changing word "captured" to "conquered". Would that make it clearer?
ddeanbrown Yes, thanks. In the context with all the mentions of "units", "captured" made me think of capturing units, which doesn't make sense.
3.0.0-beta3
Bug in file helpdata.c, routine helptext_extra(), line 3652, the block starting with
if (territory_claiming_base(pbase)) {
looks wrong, maybe it should not be there. There's a similar block starting with the same if() starting at line 3689 that looks like the correct one.