Saving options from optiondialog ignores changes
The problem is with server settings. Client can only send requests to the server to change the setting, but would then need to wait for the server to send actually changed settings (which can be only some of the settings, or even nothing at all), and this wait would need to be made so that the client main loop handles those server messages.
So not as easy as I thought.
Reply To cazfi
The problem is with server settings. Client can only send requests to the server to change the setting, but would then need to wait for the server to send actually changed settings (which can be only some of the settings, or even nothing at all), and this wait would need to be made so that the client main loop handles those server messages.
The solution would for the client to send some serial number to server after new option value, and server to reply with that same serial message when it has processed all the options that it received before it.
Based on reports by Dino The Dinosore in http://forum.freeciv.org/f/viewtopic.php?f=9&p=104765
"Save" in client option dialog confusingly does not save what user has just set and sees in the dialog, but what has actually been applied, i.e, one has to first "Apply" and then "Save". I see no reason for this behavior, but clicking "Save" should automatically include the apply step.
Both gtk- and Qt-client affected, sdl2-client likely not (setting component to "client common") though the bug is in each client's gui part.