Ticket #44129

S3_0 legacysave.c nplayers check only when asserts enabled

Open Date: 2022-03-17 10:23 Last Update: 2022-03-18 23:42

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
2

Details

S3_0 legacysave.c checks consistency on player count from the savegame in an assert(). That's wrong as savegame is external data, that can be wrong even if the freeciv program is correct. The consistency should be checked also when asserts (for programs internal logic) are not enabled.

Ticket History (3/5 Histories)

2022-03-17 10:23 Updated by: cazfi
  • New Ticket "S3_0 legacysave.c nplayers check only when asserts enabled" created
2022-03-17 10:29 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

Also S2_6 version attached, without introducing new translatable string.

2022-03-18 23:42 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login