Editor: removing a king kills player
As you set target to 3.0.1 when we already target most stuff to 3.0.2, is that to be taken as a promise that you do this yourself? The fix is likely to contain translatable strings, and if so, the patch needs to pass review period before the string freeze begins -> needs to be set "Accepted" at least 36h before 6.4 21:00 UTC -> 5.4 09:00 UTC
( 3.0.1 schedule as currently planned on freeciv-dev mailing list: https://www.freelists.org/post/freeciv-dev/301,5 )
Well, it seems small enough (what translatable strings?), probably I'll do it soon.
Ready. Tested on S3.0...3.2.
alienvalkyrie Looks good.
Without having tested it myself yet – does this also affect gameloss units killed by loss of native tiles due to edited terrain? (I'm assuming the answer is "no".) Having tested it now, the answer is "no".
Do we want it to also affect that? (I'm assuming the answer is "for simplicity's sake, no".) If yes, are you planning on adding that to this patch, or making it a separate ticket?
alienvalkyrie)
Reply To alienvalkyrie
Looks good.
Without having tested it myself yet –does this also affect gameloss units killed by loss of native tiles due to edited terrain?(I'm assuming the answer is "no".)Having tested it now, the answer is "no".
Do we want it to also affect that? (I'm assuming the answer is "for simplicity's sake, no".) If yes, are you planning on adding that to this patch, or making it a separate ticket?
Actually, I did not think about it, neither do I plan it now. If you want it, feel free to do it ;)
UPD: A side effect detected, Lua (Unit):kill("editor") also will not destroy a nation if applied to a Leader.
alienvalkyrie Reply To ihnatus
Reply To alienvalkyrie
Do we want it to also affect that? (I'm assuming the answer is "for simplicity's sake, no".) If yes, are you planning on adding that to this patch, or making it a separate ticket?
Actually, I did not think about it, neither do I plan it now. If you want it, feel free to do it ;)
I don't think it's worth the hassle; it would probably require a whole notion of "indirect cause" (which might be neat, but not necessarily useful in most other places).
UPD: A side effect detected, Lua (Unit):kill("editor") also will not destroy a nation if applied to a Leader.
That's a sensible change anyhow. I've documented it on the wiki.
We could create a gameloss unit by mistake or something. There should be a way to remove it without usual game consequences for the nation. If we want to kill a player in editor, we have a special command for it.