Ticket #44503

Wrong message when contacting _again_ a nation

Open Date: 2022-05-03 21:16 Last Update: 2023-04-07 13:02

Reporter:
Owner:
(None)
Type:
Status:
Open
Component:
(None)
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
None
File:
1

Details

3.0.1 , ailevel hard or higher

My nation was in peace with Iraq, then contact was lost.

Later, the contact was established again, and the same agressive message as in first contact occured. But we are in peace, so this message is wrong.

Ticket History (3/12 Histories)

2022-05-03 21:16 Updated by: alain_bkr
  • New Ticket "Wrong message when contacting _again_ a nation" created
2022-05-31 07:24 Updated by: cazfi
Comment

Maybe relevant: AI type (apparently the only one the server had been built with) is 'tex'.

2022-05-31 07:34 Updated by: cazfi
Comment

The diplstate information in the savegame says (consistently both directions) that Nader and Saddam are currently in "Peace", but that the closest relation they have ever had is "Never Met"

2022-05-31 07:51 Updated by: cazfi
Comment

Reply To cazfi

currently in "Peace", but that the closest relation they have ever had is "Never Met"

Should have sanity check against that -> #44732

2022-06-06 10:17 Updated by: cazfi
Comment

While there seems to be number of issues in keeping max_state updated, it's probably not the root cause of the behavior seen in the original report.

make_contact() checks for current diplstate, not max_state, before handling "new contact". And what I gather from the code, that diplstate should never go back to DS_NO_CONTACT even when contact is lost (loss of contact just means contact turns counter having reached zero)

2022-06-11 21:51 Updated by: cazfi
2022-08-05 08:57 Updated by: cazfi
2022-10-07 09:26 Updated by: cazfi
2022-12-07 02:52 Updated by: cazfi
Comment

This is sort of waiting that someone sees that again, and can provide more info (added asserts and logging should provide that the next time this happens)

2023-01-29 01:23 Updated by: cazfi
2023-04-07 13:02 Updated by: cazfi

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login