helptext_building() assumes that nukes have tech requirement

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: Client common
• MileStone: 3.0.3 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 3

Details Reply

helptext_building():

cat_snprintf(buf, bufsz,
/* TRANS: 'Allows all players with knowledge of atomic
* power to build nuclear units.' */
_("%s Allows all players with knowledge of %s "
"to build %s units.\n"), BULLET,
advance_name_translation(u->require_advance),
utype_name_translation(u));

---

That doesn't consider the possibility that the unit has no (valid) tech requirement. I don't think the effects would be more dire than funny texts ("...knowledge of Never to build...")

Ticket History (3/6 Histories)

2022-06-25 09:34 Updated by: cazfi

• New Ticket "helptext_building() assumes that nukes have tech requirement" created

2022-07-02 23:16 Updated by: cazfi

• File 0042-helpdata.c-Check-if-building-enabled-nuke-has-tech-r.patch (File ID: 9666) is attached

2022-07-02 23:17 Updated by: cazfi

• File 0028-helpdata.c-Check-if-building-enabled-nuke-has-tech-r.patch (File ID: 9667) is attached

2022-07-02 23:17 Updated by: cazfi

• File 0022-helpdata.c-Check-if-building-enabled-nuke-has-tech-r.patch (File ID: 9668) is attached

2022-07-02 23:17 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from (None) to 3.0.3 (closed)

2022-07-08 07:14 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed