Ticket #44953

canvas_put_sprite_full_scaled()

Open Date: 2022-06-26 21:00 Last Update: 2022-07-06 07:21

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

We need canvas_put_sprite_full_scaled() in the gui API to make better .svg support (regardless of the exact form of that support, and .svg in theory meaning any vector format). Existing canvas_put_sprite_full() gets the canvas size from the source sprite, not scaling in any way.

The most easily reproducible problem with canvas_put_sprite_full() and .svg is making the client prefer .svg over .png, ant to use flags.spec (not flags-large.spec - then the expected file names would not match the .svg files we have), found a city. Depending on your nation -> the image size defined for the .svg, you get either half, or all of, your screen filled with the map.

Ticket History (3/5 Histories)

2022-06-26 21:00 Updated by: cazfi
  • New Ticket "canvas_put_sprite_full_scaled()" created
2022-06-26 21:08 Updated by: cazfi
  • Milestone Update from (None) to 3.2.0
  • Component Update from (None) to Client common
2022-06-26 21:44 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
Comment

API change attached. Qt-client has also the implementation I've been testing with. Other clients have just dummies.

2022-07-06 07:21 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login