Ticket #44958

S3_0 savegame "unused entry" warnings about activities order

Open Date: 2022-06-27 09:21 Last Update: 2022-06-30 06:19

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

We added saving of the activities order in freeciv-3.0 already, for the benefit of the future versions loading such savegames, while freeciv-3.0 itself does not use them from the savegame. Now, when one loads such a savegame in freeciv-3.0 itself with deprecation warnings enabled, there's a lot of "unused entry" warnings about the activities order related entries.

Loading e.g. tutorial scenario gives similar warnings about some other "order" vectors, but I've not checked if their case is exactly the same, or is something else going in with them -> check the situation and depending on the result either handle them under this ticket, or open a new one.

There's also #44809 about unused entries, but that seems completely different case.

Ticket History (3/6 Histories)

2022-06-27 09:21 Updated by: cazfi
  • New Ticket "S3_0 savegame "unused entry" warnings about activities order" created
2022-06-27 09:21 Updated by: cazfi
  • Details Updated
2022-06-27 10:00 Updated by: cazfi
Comment

Reply To cazfi

Loading e.g. tutorial scenario gives similar warnings about some other "order" vectors, but I've not checked if their case is exactly the same, or is something else going in with them -> check the situation and depending on the result either handle them under this ticket, or open a new one.

They differ in that those entries are still unused also in newer versions. I'd rather leave them out from this ticket. I've opened tickets about implementing their real loading: #44959 and #44960.

2022-06-27 10:03 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
2022-06-30 06:19 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login