Ticket #44993

generate_packets.py: use FC_FREE macro

Open Date: 2022-07-04 00:08 Last Update: 2022-07-05 18:41

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Split from discussion in #44977; related to hrm#745593.

Reply To cazfi

... change to use FC_FREE() instead of free() + "... = NULL;" for some fields. Not sure if we want to do that, but if we do, it should go to separate ticket and then handle also other similar cases in generate_packets.py.

There are currently 13 such cases, as well as one use of free() without ... = NULL; (which would cause problems if there were any packets with both pre-send and post-send hooks).

Ticket History (3/5 Histories)

2022-07-04 00:08 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: use FC_FREE macro" created
2022-07-04 02:26 Updated by: alienvalkyrie
  • Resolution Update from None to Accepted
  • Type Update from Bugs to Patches
Comment

The mentioned special case is nontrivial to work with, so I'll make a separate ticket for that.

2022-07-04 02:29 Updated by: alienvalkyrie
Comment

Reply To alienvalkyrie

The mentioned special case is nontrivial to work with, so I'll make a separate ticket for that.

~> #44996

2022-07-05 18:41 Updated by: alienvalkyrie
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Attachment File List

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login