Ticket #45149

Qt: Badly adjusted UI for trading_gold = disabled

Open Date: 2022-07-18 23:53 Last Update: 2022-07-25 11:32

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

I was starting to look at https://www.hostedredmine.com/issues/768422 (for branches with ruleset defined clauses), but noticed that Qt-client's existing handling of trading_gold server setting isn't very sane. All the widgets are there either way. The only difference is that when gold trading is enabled, the amount you can enter is limited by the amount of gold actually available. When gold trading is disabled, you can enter any value.

Ticket History (3/8 Histories)

2022-07-18 23:53 Updated by: cazfi
  • New Ticket "Qt: Bady adjusted UI for trading_gold = disabled" created
2022-07-18 23:56 Updated by: cazfi
  • Summary Updated
2022-07-19 00:20 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.0.3 (closed)
Comment

Reply To cazfi

the amount you can enter is limited by the amount of gold actually available.

Which is likely buggy in that I don't see it adjusted later if the player loses and gains gold outside the specific negotiation. -> maybe open a new ticket

Patch for the issue of this ticket attached.

2022-07-25 11:22 Updated by: cazfi
Comment

Reply To cazfi

Reply To cazfi

the amount you can enter is limited by the amount of gold actually available.

Which is likely buggy in that I don't see it adjusted later if the player loses and gains gold outside the specific negotiation. -> maybe open a new ticket

-> #45229

2022-07-25 11:32 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login