S3_0 array-bounds compiler error in Xenial

• Reporter: cazfi
• Owner: cazfi
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.0.5 (closed)
• Priority: 8
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Now that we've again enabled array-bounds warnings in S3_0 also, build on Xenial seems to fail. It complains about activity_id_exists(). I don't see anything wrong with the function, and the fact that no newer compiler (with better heuristics) gives such warning leads me to believe it's a false positive. There's no similar problem with other branches.

So I think it's enough to just rearrange the code so that gcc-5.4 no longer complains about it, and not to look for an actual bug.

Will treat as a build emergency.

Ticket History (3/4 Histories)

2022-10-13 22:56 Updated by: cazfi

• New Ticket "S3_0 array-bounds compiler error in Xenial" created

2022-10-13 23:05 Updated by: cazfi

• File 0001-Reimplement-action_id_exists-to-silence-gcc-5.4-arra.patch (File ID: 10563) is attached

2022-10-13 23:05 Updated by: cazfi

• Owner Update from (None) to cazfi
• Resolution Update from None to Accepted

Comment

Patch to push to S3_0 only attached.

2022-10-13 23:06 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed