Ticket #46497

convert_string() error spam

Open Date: 2023-01-09 22:30 Last Update: 2023-01-23 22:14

Reporter:
Owner:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

convert_string() iconv failing should not be a big issue, as then it just uses the original string as a fallback, and most of the time that string is just perfect.

What makes server console unusable in case of failing conversion is that convert_string() logs an error for every call where it fails, spamming the console with hundreds of messages.

Ticket History (3/9 Histories)

2023-01-09 22:30 Updated by: cazfi
  • New Ticket "convert_string() error spam" created
2023-01-10 22:12 Updated by: cazfi
Comment

This was detected on Msys2 "win64-10" build failing those iconv calls. The failure seems to be specific to those ("win64" builds from the same source work / of "win64-10" builds both autotools and meson builds affected, as well as both branches where "win64-10" builds are available)

As "win64-10" is the default build, the issue counts as a regression between S3_0 -> S3_1 default Windows build.

2023-01-20 07:34 Updated by: cazfi
  • Owner Update from (None) to cazfi
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.0.6 (closed)
2023-01-22 00:36 Updated by: cazfi
Comment

Attached also S2_6 patch. This does not restart review time for later branches.

2023-01-22 17:20 Updated by: cazfi
Comment

Pushed to master/S3_1/S3_0, S2_6 waits.

2023-01-23 22:14 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login