[Groonga-commit] groonga/gcs [master] Use constant index of literals for the default domain id

Back to archive index

null+****@clear***** null+****@clear*****
2012年 8月 2日 (木) 16:20:55 JST


SHIMODA Hiroshi	2012-08-02 16:20:55 +0900 (Thu, 02 Aug 2012)

  New Revision: 68c0e2f571c62dda3ab765675377f1b96a9468f7
  https://github.com/groonga/gcs/commit/68c0e2f571c62dda3ab765675377f1b96a9468f7

  Log:
    Use constant index of literals for the default domain id

  Modified files:
    test/database-domain.test.js
    test/database-index-field.test.js

  Modified: test/database-domain.test.js (+3 -3)
===================================================================
--- test/database-domain.test.js    2012-08-02 16:16:09 +0900 (eaece73)
+++ test/database-domain.test.js    2012-08-02 16:20:55 +0900 (265b27d)
@@ -24,13 +24,13 @@ suite('database', function() {
     test('lower case', function() {
       var domain = new Domain('valid');
       domain.id = Domain.DEFAULT_ID;
-      assert.equal(domain.tableName, 'valid_00000000000000000000000000');
+      assert.equal(domain.tableName, 'valid_' + Domain.DEFAULT_ID);
     });
 
     test('lower case and number', function() {
       var domain = new Domain('valid123');
       domain.id = Domain.DEFAULT_ID;
-      assert.equal(domain.tableName, 'valid123_00000000000000000000000000');
+      assert.equal(domain.tableName, 'valid123_' + Domain.DEFAULT_ID);
     });
 
     test('too short', function() {
@@ -67,7 +67,7 @@ suite('database', function() {
     test('termsTableName', function() {
       var domain = new Domain('valid123');
       domain.id = Domain.DEFAULT_ID;
-      assert.equal(domain.termsTableName, 'valid123_00000000000000000000000000_BigramTerms');
+      assert.equal(domain.termsTableName, 'valid123_' + Domain.DEFAULT_ID + '_BigramTerms');
     });
 
     suite('from query parameter', function() {

  Modified: test/database-index-field.test.js (+3 -3)
===================================================================
--- test/database-index-field.test.js    2012-08-02 16:16:09 +0900 (7a28787)
+++ test/database-index-field.test.js    2012-08-02 16:20:55 +0900 (e4b0d28)
@@ -63,12 +63,12 @@ suite('database', function() {
 
     test('indexColumnName', function() {
       var field = new IndexField('valid_123', domain);
-      assert.equal(field.indexColumnName, 'testdomain_00000000000000000000000000_valid_123');
+      assert.equal(field.indexColumnName, 'testdomain_' + Domain.DEFAULT_ID + '_valid_123');
     });
 
     test('alterTableName', function() {
       var field = new IndexField('valid_123', domain);
-      assert.equal(field.alterTableName, 'testdomain_00000000000000000000000000_valid_123');
+      assert.equal(field.alterTableName, 'testdomain_' + Domain.DEFAULT_ID + '_valid_123');
     });
 
     test('fieldTypeToColumnType (text)', function() {
@@ -86,7 +86,7 @@ suite('database', function() {
     test('fieldTypeToColumnType (literal)', function() {
       var field = new IndexField('valid_123', domain);
       assert.equal(field.fieldTypeToColumnType('literal'),
-                   'testdomain_00000000000000000000000000_valid_123');
+                   'testdomain_' + Domain.DEFAULT_ID + '_valid_123');
     });
 
     test('initial status (text)', function() {
-------------- next part --------------
HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...
Download 



Groonga-commit メーリングリストの案内
Back to archive index