[Groonga-commit] groonga/gcs [master] bq: throw exception for invalid operator chracter

Back to archive index

null+****@clear***** null+****@clear*****
2012年 8月 6日 (月) 13:17:22 JST


Kouhei Sutou	2012-08-06 13:17:22 +0900 (Mon, 06 Aug 2012)

  New Revision: 5fe20dd48018a21a59e8885d9f8be74d6dced453
  https://github.com/groonga/gcs/commit/5fe20dd48018a21a59e8885d9f8be74d6dced453

  Log:
    bq: throw exception for invalid operator chracter

  Modified files:
    lib/bq-translator.js
    test/bq-translator.test.js

  Modified: lib/bq-translator.js (+2 -2)
===================================================================
--- lib/bq-translator.js    2012-08-06 13:14:29 +0900 (60118d0)
+++ lib/bq-translator.js    2012-08-06 13:17:22 +0900 (1e97797)
@@ -100,8 +100,8 @@ BooleanQueryTranslator.prototype = {
       } else if (character == ")") {
         this.throwTranslateError("operator is missing");
       } else {
-        // TODO: invalid operator
-        return "";
+        this.throwTranslateError("invalid operator character: " +
+                                 "<" + character + ">");
       }
     }
 

  Modified: test/bq-translator.test.js (+4 -0)
===================================================================
--- test/bq-translator.test.js    2012-08-06 13:14:29 +0900 (a0f88f0)
+++ test/bq-translator.test.js    2012-08-06 13:17:22 +0900 (8229d7d)
@@ -138,6 +138,10 @@ suite('BoolanQueryTranslator', function() {
                  "()",
                  "(|)|",
                  "operator is missing");
+  testGroupError("invalid operator character",
+                 "(operat0r f1:'k1' f2:'k2')",
+                 "(operat|0|r f1:'k1' f2:'k2')",
+                 "invalid operator character: <0>");
 
   testExpression("value only: stirng: and: space",
                  "'keyword1 keyword2' 'other keyword'",
-------------- next part --------------
HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...
Download 



Groonga-commit メーリングリストの案内
Back to archive index