null+****@clear*****
null+****@clear*****
2012年 8月 6日 (月) 14:09:23 JST
Kouhei Sutou 2012-08-06 14:09:23 +0900 (Mon, 06 Aug 2012) New Revision: 6b55ec3eda3b0ecd11aae948703f625dcb8e1ac1 https://github.com/groonga/gcs/commit/6b55ec3eda3b0ecd11aae948703f625dcb8e1ac1 Log: bq: throw exception for invalid value Modified files: lib/bq-translator.js test/bq-translator.test.js Modified: lib/bq-translator.js (+2 -2) =================================================================== --- lib/bq-translator.js 2012-08-06 14:07:20 +0900 (785b932) +++ lib/bq-translator.js 2012-08-06 14:09:23 +0900 (66e2903) @@ -218,8 +218,8 @@ BooleanQueryTranslator.prototype = { if (/^[0-9.]/.test(this.query[this.offset])) { return this.translateExpressionValueUnsignedInteger(field); } - // TODO: report error - return ""; + + this.throwTranslateError("invalid value: field:<" + field + ">"); }, translateExpressionValueString: function(field) { if (this.query[this.offset] != "'") { Modified: test/bq-translator.test.js (+4 -0) =================================================================== --- test/bq-translator.test.js 2012-08-06 14:07:20 +0900 (4deb948) +++ test/bq-translator.test.js 2012-08-06 14:09:23 +0900 (5038099) @@ -258,4 +258,8 @@ suite('BoolanQueryTranslator', function() { "f1 'k1'", "f1| |'k1'", "field value separator is missing"); + testExpressionError("invalid value", + "f1:value", + "f1:|v|alue", + "invalid value: field:<f1>"); }); -------------- next part -------------- HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...Download