[Groonga-commit] groonga/gcs [master] Extract logic to get specified field options

Back to archive index

SHIMODA Hiroshi null+****@clear*****
Mon Aug 13 17:44:53 JST 2012


SHIMODA Hiroshi	2012-08-13 17:44:53 +0900 (Mon, 13 Aug 2012)

  New Revision: 2be69551cbbcb1df5fa959add2232a042012982f
  https://github.com/groonga/gcs/commit/2be69551cbbcb1df5fa959add2232a042012982f

  Log:
    Extract logic to get specified field options

  Modified files:
    lib/api/2011-02-01/configuration.js

  Modified: lib/api/2011-02-01/configuration.js (+12 -13)
===================================================================
--- lib/api/2011-02-01/configuration.js    2012-08-13 17:38:27 +0900 (97f9c28)
+++ lib/api/2011-02-01/configuration.js    2012-08-13 17:44:53 +0900 (f51af83)
@@ -229,6 +229,15 @@ function createDefineIndexFieldResponse(options) {
   return doc.toString();
 }
 
+function getFieldOption(option, request, type) {
+  if (fieldType == 'text')
+    return request.query['TextOptions.' + option];
+  if (fieldType == 'literal')
+    return request.query['LiteralOptions.' + option];
+  else
+    return request.query['UIntOptions.' + option];
+}
+
 handlers.DefineIndexField = function(context, request, response) {
   var domain = new Domain(request.query.DomainName, context);
 
@@ -238,25 +247,15 @@ handlers.DefineIndexField = function(context, request, response) {
 
   var createdAt = new Date();
   try {
-    var facetEnabled = fieldType == 'text' ?
-                         request.query['TextOptions.FacetEnabled'] :
-                       fieldType == 'literal' ?
-                         request.query['LiteralOptions.FacetEnabled'] :
-                         undefined ;
+    var facetEnabled = getFieldOption('FacetEnabled', request, fieldType);
     if (facetEnabled !== undefined)
       field.facetEnabled = facetEnabled.toLowerCase() == 'true';
 
-    var resultEnabled = fieldType == 'text' ?
-                          request.query['TextOptions.ResultEnabled'] :
-                        fieldType == 'literal' ?
-                          request.query['LiteralOptions.ResultEnabled'] :
-                          undefined ;
+    var resultEnabled = getFieldOption('ResultEnabled', request, fieldType);
     if (resultEnabled !== undefined)
       field.resultEnabled = resultEnabled.toLowerCase() == 'true';
 
-    var searchEnabled = fieldType == 'literal' ?
-                          request.query['LiteralOptions.SearchEnabled'] :
-                          undefined ;
+    var searchEnabled = getFieldOption('SearchEnabled', request, fieldType);
     if (searchEnabled !== undefined)
       field.searchEnabled = searchEnabled.toLowerCase() == 'true';
 
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index