[Groonga-commit] groonga/gcs [master] Monkey patching is no longer needed

Back to archive index

Yoji SHIDARA null+****@clear*****
Thu Dec 13 11:25:49 JST 2012


Yoji SHIDARA	2012-12-13 11:25:49 +0900 (Thu, 13 Dec 2012)

  New Revision: 448de09a4b5c774ab4f4080b34769a22c6f71cf2
  https://github.com/groonga/gcs/commit/448de09a4b5c774ab4f4080b34769a22c6f71cf2

  Log:
    Monkey patching is no longer needed
    
    The patch is accepted at xmlbuilder mainstream.

  Removed files:
    lib/xmlbuilder.js
  Modified files:
    lib/api/2011-02-01/configuration.js
    lib/api/2011-02-01/search.js

  Modified: lib/api/2011-02-01/configuration.js (+1 -1)
===================================================================
--- lib/api/2011-02-01/configuration.js    2012-12-12 19:39:22 +0900 (b710940)
+++ lib/api/2011-02-01/configuration.js    2012-12-13 11:25:49 +0900 (2a71dd2)
@@ -3,7 +3,7 @@ var nroonga = require('../../wrapped-nroonga');
 var Domain = require('../../database').Domain;
 var IndexField = require('../../database').IndexField;
 var dateFormat = require('dateformat');
-var xmlbuilder = require('../../xmlbuilder');
+var xmlbuilder = require('xmlbuilder');
 var ipv4 = require('../../ipv4');
 var logger = require('../../logger');
 var errors = require('../../errors');

  Modified: lib/api/2011-02-01/search.js (+1 -1)
===================================================================
--- lib/api/2011-02-01/search.js    2012-12-12 19:39:22 +0900 (1cb6d41)
+++ lib/api/2011-02-01/search.js    2012-12-13 11:25:49 +0900 (b7ad798)
@@ -3,7 +3,7 @@
 var SelectQuery = require('../../select-query').SelectQuery;
 var IndexField = require('../../database').IndexField;
 var logger = require('../../logger');
-var xmlbuilder = require('../../xmlbuilder');
+var xmlbuilder = require('xmlbuilder');
 
 var dummyRid = '000000000000000000000000000000000000000000000000000000000000000';
 

  Deleted: lib/xmlbuilder.js (+0 -24) 100644
===================================================================
--- lib/xmlbuilder.js    2012-12-12 19:39:22 +0900 (6b9b127)
+++ /dev/null
@@ -1,24 +0,0 @@
-module.exports = require('xmlbuilder');
-
-var XMLFragment = require('xmlbuilder/lib/XMLFragment');
-
-XMLFragment.prototype.importXMLBuilder = function(xmlbuilder) {
-  var root = xmlbuilder.children[xmlbuilder.children.length-1];
-  var clonedRoot = root.clone(true);
-  clonedRoot.parent = this;
-  this.children.push(clonedRoot);
-  clonedRoot.isRoot = false;
-  return this;
-};
-
-XMLFragment.prototype.clone = function(deep) {
-  var clonedSelf = new XMLFragment(this.parent, this.name, this.attributes, this.value);
-  if (deep) {
-    this.children.forEach(function(child) {
-      var clonedChild = child.clone(deep);
-      clonedChild.parent = clonedSelf;
-      clonedSelf.children.push(clonedChild);
-    }, this);
-  }
-  return clonedSelf;
-};
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index