[Groonga-commit] groonga/gcs [master] BqTranslator: use exception to detect error

Back to archive index

null+****@clear***** null+****@clear*****
2012年 7月 27日 (金) 18:25:20 JST


Kouhei Sutou	2012-07-27 18:25:20 +0900 (Fri, 27 Jul 2012)

  New Revision: 98d89ea4056631302b521b778b4ce47e3b38c15d
  https://github.com/groonga/gcs/commit/98d89ea4056631302b521b778b4ce47e3b38c15d

  Log:
    BqTranslator: use exception to detect error

  Modified files:
    lib/api/2011-02-01/search.js

  Modified: lib/api/2011-02-01/search.js (+4 -5)
===================================================================
--- lib/api/2011-02-01/search.js    2012-07-27 18:17:09 +0900 (9a65f64)
+++ lib/api/2011-02-01/search.js    2012-07-27 18:25:20 +0900 (2f81e53)
@@ -63,13 +63,12 @@ exports.createHandler = function(context) {
     if (booleanQuery) {
       var translator = new BooleanQueryTranslator();
       var defaultField = "default_field_fixme"; // FIXME
-      var translatedQuery = translator.translate(booleanQuery, defaultField);
-      if (translatedQuery) {
-        filter = translatedQuery;
-      } else {
+      try {
+        filter = translator.translate(booleanQuery, defaultField);
+      } catch (error) {
         var body = createErrorBody({
           rid: dummyRid,
-          message: 'Unsupported bq parameter'
+          message: 'Invalid bq value: ' + (error.message || error)
         });
         return response.send(body, 400);
       }
-------------- next part --------------
HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...
Download 



Groonga-commit メーリングリストの案内
Back to archive index