[Groonga-commit] groonga/fluent-plugin-droonga [master] Use "message" as column name

Back to archive index

Daijiro MORI null+****@clear*****
Fri Apr 5 07:25:47 JST 2013


Daijiro MORI	2013-04-05 07:25:47 +0900 (Fri, 05 Apr 2013)

  New Revision: 0d4750cfb3f762226b814a0084c1ae4028b901db
  https://github.com/groonga/fluent-plugin-droonga/commit/0d4750cfb3f762226b814a0084c1ae4028b901db

  Message:
    Use "message" as column name
    
    Because "request" is inappropriate for its semantics.

  Modified files:
    lib/droonga/job_queue_schema.rb
    lib/droonga/worker.rb
    test/test_job_queue_schema.rb

  Modified: lib/droonga/job_queue_schema.rb (+1 -1)
===================================================================
--- lib/droonga/job_queue_schema.rb    2013-04-05 07:02:32 +0900 (df42ac8)
+++ lib/droonga/job_queue_schema.rb    2013-04-05 07:25:47 +0900 (97dd3fe)
@@ -46,7 +46,7 @@ module Droonga
         context.open_database(@database_path) do
           Groonga::Schema.define(:context => context) do |schema|
             schema.create_table(@queue_name, :type => :array) do |table|
-              table.text("request")
+              table.text("message")
             end
           end
         end

  Modified: lib/droonga/worker.rb (+7 -7)
===================================================================
--- lib/droonga/worker.rb    2013-04-05 07:02:32 +0900 (525e6ab)
+++ lib/droonga/worker.rb    2013-04-05 07:25:47 +0900 (b2061df)
@@ -59,24 +59,24 @@ module Droonga
       end
       queue = @context[@queue_name]
       while !@finish
-        request = nil
+        message = nil
         queue.pull do |record|
           @status = :BUSY
-          request = record.request if record
+          message = record.message if record
         end
-        if request
-          envelope = MessagePack.unpack(request)
-          process_message(envelope) if request
+        if message
+          envelope = MessagePack.unpack(message)
+          process_message(envelope) if message
         end
         @status = :IDLE
       end
     end
 
     def post_message(envelope)
-      request = envelope.to_msgpack
+      message = envelope.to_msgpack
       queue = @context[@queue_name]
       queue.push do |record|
-        record.request = request
+        record.message = message
       end
     end
 

  Modified: test/test_job_queue_schema.rb (+1 -1)
===================================================================
--- test/test_job_queue_schema.rb    2013-04-05 07:02:32 +0900 (94bd2c3)
+++ test/test_job_queue_schema.rb    2013-04-05 07:25:47 +0900 (9966dc9)
@@ -39,7 +39,7 @@ class JobQueueSchemaTest < Test::Unit::TestCase
     context.close
     assert_equal(<<-SCHEMA, dumped_commands)
 table_create #{@queue_name} TABLE_NO_KEY
-column_create #{@queue_name} request COLUMN_SCALAR Text
+column_create #{@queue_name} message COLUMN_SCALAR Text
 SCHEMA
   end
 end
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index