Yoji Shidara
null+****@clear*****
Thu Dec 19 12:24:06 JST 2013
Yoji Shidara 2013-12-19 12:24:06 +0900 (Thu, 19 Dec 2013) New Revision: 0d46e708930d800152f8ed5b01d4fd666e024ad7 https://github.com/droonga/fluent-plugin-droonga/commit/0d46e708930d800152f8ed5b01d4fd666e024ad7 Message: Use case/when instead of chaining if Modified files: lib/droonga/searcher.rb Modified: lib/droonga/searcher.rb (+6 -4) =================================================================== --- lib/droonga/searcher.rb 2013-12-19 12:14:04 +0900 (1ddedcc) +++ lib/droonga/searcher.rb 2013-12-19 12:24:06 +0900 (2ddac83) @@ -256,9 +256,10 @@ module Droonga def apply_group_by!(group_by) $log.trace("#{log_tag}: search_query: group: start", :by => group_by) - if group_by.is_a? String + case group_by + when String @result =****@resul*****(group_by) - elsif group_by.is_a? Hash + when Hash key = group_by["key"] max_n_sub_records = group_by["maxNSubRecords"] @result =****@resul*****(key, :max_n_sub_records => max_n_sub_records) @@ -272,11 +273,12 @@ module Droonga def apply_sort_by!(sort_by) $log.trace("#{log_tag}: search_query: sort: start", :by => sort_by) - if sort_by.is_a? Array + case sort_by + when Array keys = parse_order_keys(sort_by) offset = 0 limit = -1 - elsif sort_by.is_a? Hash + when Hash keys = parse_order_keys(sort_by["keys"]) offset = sort_by["offset"] limit = sort_by["limit"] -------------- next part -------------- HTML����������������������������...Download