[Groonga-commit] groonga/express-kotoumi [master] Generate list of available socket.io commands at first

Back to archive index

YUKI Hiroshi null+****@clear*****
Wed Feb 6 12:49:35 JST 2013


YUKI Hiroshi	2013-02-06 12:49:35 +0900 (Wed, 06 Feb 2013)

  New Revision: 65ba197e3ba477ce876a4b35270829a1c61300f1
  https://github.com/groonga/express-kotoumi/commit/65ba197e3ba477ce876a4b35270829a1c61300f1

  Log:
    Generate list of available socket.io commands at first

  Modified files:
    test/test-utils.js

  Modified: test/test-utils.js (+9 -12)
===================================================================
--- test/test-utils.js    2013-02-06 12:42:56 +0900 (1d51e8a)
+++ test/test-utils.js    2013-02-06 12:49:35 +0900 (68e09a6)
@@ -6,7 +6,13 @@ var http = require('http');
 var Deferred = require('jsdeferred').Deferred;
 var client = require('socket.io-client');
 
-var socketIoDefaultCommands = require('../lib/frontend/default-commands/socket.io');
+var socketIoDefaultCommandsModule = require('../lib/frontend/default-commands/socket.io');
+var socketIoDefaultCommands = [];
+Object.keys(socketIoDefaultCommandsModule).forEach(function(command) {
+  if (!command || typeof command != 'object')
+    return;
+  socketIoDefaultCommands.push(command);
+});
 
 var testSendPort = exports.testSendPort = 3333;
 var testReceivePort = exports.testReceivePort = 3334;
@@ -138,9 +144,7 @@ exports.createClientSocket = createClientSocket;
 function createMockedBackendConnection() {
   var connection = nodemock;
   var onMessageControllers = {};
-  Object.keys(socketIoDefaultCommands).forEach(function(command) {
-    if (!command || typeof command != 'object')
-      return;
+  socketIoDefaultCommands.forEach(function(command) {
     onMessageControllers[command] = {};
     connection = connection
       .mock('on')
@@ -172,17 +176,10 @@ function createStubbedBackendConnection() {
 exports.createStubbedBackendConnection = createStubbedBackendConnection;
 
 function readyToDestroyMockedConnection(connection) {
-  var commands = [];
-  Object.keys(socketIoDefaultCommands).forEach(function(command) {
-    if (!command || typeof command != 'object')
-      return;
-    commands.push(command);
-  });
-
   connection = connection
     .mock('removeListener')
       .takes('message', function() {})
-      .times(commands.length)
+      .times(socketIoDefaultCommands.length)
     .mock('removeListener')
       .takes('error', function() {});
   return connection;
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index