YUKI Hiroshi
null+****@clear*****
Wed Feb 13 18:37:28 JST 2013
YUKI Hiroshi 2013-02-13 18:37:28 +0900 (Wed, 13 Feb 2013) New Revision: 61ff7a8d634b5a7d006860d6e4411d879031d4fa https://github.com/groonga/express-kotoumi/commit/61ff7a8d634b5a7d006860d6e4411d879031d4fa Log: test: Simplify assertions by helper function Modified files: test/backend-connection.test.js Modified: test/backend-connection.test.js (+15 -7) =================================================================== --- test/backend-connection.test.js 2013-02-13 18:32:28 +0900 (48b6d33) +++ test/backend-connection.test.js 2013-02-13 18:37:28 +0900 (fbabae2) @@ -102,7 +102,14 @@ suite('Connection', function() { return callback; } + function getBackendReceivedMessages() { + return backend.received.map(function(packet) { + return packet[2]; + }); + } + suite('one way message', function() { + test('from front to back', function(done) { var objectMessage = connection.emitMessage('object', { command: 'foobar' }); assert.envelopeEqual(objectMessage, @@ -121,9 +128,7 @@ suite('Connection', function() { .wait(0.01) .next(function() { assert.equal(backend.received.length, 3, 'messages should be sent'); - assert.deepEqual([backend.received[0][2], - backend.received[1][2], - backend.received[2][2]], + assert.deepEqual(getBackendReceivedMessages(), [objectMessage, stringMessage, numericMessage]); @@ -178,7 +183,7 @@ suite('Connection', function() { Deferred .wait(0.01) .next(function() { - assert.equal(backend.received.length, 2, 'message should be sent'); + assert.equal(getBackendReceivedMessages(), messages); assert.deepEqual( [connection.listeners('reply:' + messages[0].id).length, connection.listeners('reply:' + messages[1].id).length], @@ -223,7 +228,7 @@ suite('Connection', function() { Deferred .wait(0.01) .next(function() { - assert.equal(backend.received.length, 2, 'message should be sent'); + assert.equal(getBackendReceivedMessages(), messages); assert.deepEqual( [connection.listeners('reply:' + messages[0].id).length, connection.listeners('reply:' + messages[1].id).length], @@ -268,7 +273,7 @@ suite('Connection', function() { Deferred .wait(0.01) .next(function() { - assert.equal(backend.received.length, 2, 'message should be sent'); + assert.equal(getBackendReceivedMessages(), messages); assert.deepEqual( [connection.listeners('reply:' + messages[0].id).length, connection.listeners('reply:' + messages[1].id).length], @@ -329,7 +334,10 @@ suite('Connection', function() { Deferred .wait(0.01) .next(function() { - assert.equal(backend.received.length, 3, 'message should be sent'); + assert.deepEqual(getBackendReceivedMessages(), + [messages.notTimedOut, + messages.timedOut, + messages.permanent]); assert.deepEqual( { notTimedOut: connection.listeners('reply:' + messages.notTimedOut.id).length, -------------- next part -------------- HTML����������������������������...Download