[Groonga-commit] groonga/fluent-plugin-droonga at 64ff451 [master] test: rewrite FlagsTest for data driven testing

Back to archive index

Kosuke Asami null+****@clear*****
Mon Jul 15 15:37:50 JST 2013


Kosuke Asami	2013-07-15 15:37:50 +0900 (Mon, 15 Jul 2013)

  New Revision: 64ff45188149522754a959493d556c7800fd709a
  https://github.com/groonga/fluent-plugin-droonga/commit/64ff45188149522754a959493d556c7800fd709a

  Message:
    test: rewrite FlagsTest for data driven testing

  Modified files:
    test/plugin/groonga/test_table_create.rb

  Modified: test/plugin/groonga/test_table_create.rb (+37 -56)
===================================================================
--- test/plugin/groonga/test_table_create.rb    2013-07-11 16:45:52 +0900 (5acd10d)
+++ test/plugin/groonga/test_table_create.rb    2013-07-15 15:37:50 +0900 (8d814a2)
@@ -38,70 +38,51 @@ table_create Books TABLE_HASH_KEY --key_type ShortText
   end
 
   class FlagsTest < self
-    def test_table_no_key
-      request = {
-        "name"  => "Books",
-        "flags" => "TABLE_NO_KEY",
-      }
-      @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
+    data({
+           "TABLE_NO_KEY" => {
+             :flags => "TABLE_NO_KEY",
+             :schema => <<-SCHEMA,
 table_create Books TABLE_NO_KEY
-      SCHEMA
-    end
-
-    def test_table_hash_key
-      request = {
-        "name"  => "Books",
-        "flags" => "TABLE_HASH_KEY",
-      }
-      @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
+             SCHEMA
+           },
+           "TABLE_HASH_KEY" => {
+             :flags => "TABLE_HASH_KEY",
+             :schema => <<-SCHEMA,
 table_create Books TABLE_HASH_KEY --key_type ShortText
-      SCHEMA
-    end
-
-    def test_table_pat_key
-      request = {
-        "name"  => "Books",
-        "flags" => "TABLE_PAT_KEY",
-      }
-      @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
+             SCHEMA
+           },
+           "TABLE_PAT_KEY" => {
+             :flags => "TABLE_PAT_KEY",
+             :schema => <<-SCHEMA,
 table_create Books TABLE_PAT_KEY --key_type ShortText
-      SCHEMA
-    end
-
-    def test_table_dat_key
-      request = {
-        "name"  => "Books",
-        "flags" => "TABLE_DAT_KEY",
-      }
-      @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
+             SCHEMA
+           },
+           "TABLE_DAT_KEY" => {
+             :flags => "TABLE_DAT_KEY",
+             :schema => <<-SCHEMA,
 table_create Books TABLE_DAT_KEY --key_type ShortText
-      SCHEMA
-    end
-
-    def test_key_with_sis_with_pat_key
-      request = {
-        "name"  => "Books",
-        "flags" => "KEY_WITH_SIS|TABLE_PAT_KEY",
-      }
-      @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
+             SCHEMA
+           },
+           "TABLE_PAT_KEY with KEY_WITH_SIS" => {
+             :flags => "KEY_WITH_SIS|TABLE_PAT_KEY",
+             :schema => <<-SCHEMA,
 table_create Books TABLE_PAT_KEY|KEY_WITH_SIS --key_type ShortText
-      SCHEMA
-    end
-
-    def test_key_with_sis_without_pat_key
+             SCHEMA
+           },
+           "KEY_WITH_SIS without TABLE_PAT_KEY" => {
+             :flags => "TABLE_NO_KEY|KEY_WITH_SIS",
+             :schema => <<-SCHEMA,
+table_create Books TABLE_NO_KEY
+             SCHEMA
+           },
+         })
+    def test_flags(data)
       request = {
-        "name"  => "Books",
-        "flags" => "TABLE_NO_KEY|KEY_WITH_SIS",
+        "name" => "Books",
+        "flags" => data[:flags],
       }
       @handler.table_create(request)
-      assert_equal(<<-SCHEMA, dump)
-table_create Books TABLE_NO_KEY
-      SCHEMA
+      assert_equal(data[:schema], dump)
     end
   end
 
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index