[Groonga-commit] groonga/fluent-plugin-droonga at c6e5466 [master] adapter_select: delete needless prefix because class name includes command name

Back to archive index

Kosuke Asami null+****@clear*****
Tue Jul 23 14:14:11 JST 2013


Kosuke Asami	2013-07-23 14:14:11 +0900 (Tue, 23 Jul 2013)

  New Revision: c6e546613ed06f1710284fb288648ce985eeb736
  https://github.com/groonga/fluent-plugin-droonga/commit/c6e546613ed06f1710284fb288648ce985eeb736

  Message:
    adapter_select: delete needless prefix because class name includes command name

  Modified files:
    lib/droonga/plugin/adapter_groonga.rb
    lib/droonga/plugin/adapter_select.rb
    test/plugin/adapter/groonga/test_select.rb

  Modified: lib/droonga/plugin/adapter_groonga.rb (+2 -2)
===================================================================
--- lib/droonga/plugin/adapter_groonga.rb    2013-07-23 14:11:47 +0900 (9d9e505)
+++ lib/droonga/plugin/adapter_groonga.rb    2013-07-23 14:14:11 +0900 (530a1e6)
@@ -23,9 +23,9 @@ module Droonga
 
     def select(select_request)
       command = Select.new
-      search_request = command.select_convert_request(select_request)
+      search_request = command.convert_request(select_request)
       post(search_request) do |search_response|
-        command.select_convert_response(search_response)
+        command.convert_response(search_response)
       end
       :selected
     end

  Modified: lib/droonga/plugin/adapter_select.rb (+2 -2)
===================================================================
--- lib/droonga/plugin/adapter_select.rb    2013-07-23 14:11:47 +0900 (52a0ade)
+++ lib/droonga/plugin/adapter_select.rb    2013-07-23 14:14:11 +0900 (5b49c5c)
@@ -16,7 +16,7 @@
 module Droonga
   class GroongaAdapter
     class Select
-      def select_convert_request(select_request)
+      def convert_request(select_request)
         table = select_request["table"]
         output_columns = select_request["output_columns"]
         attributes = output_columns.split(/, */)
@@ -40,7 +40,7 @@ module Droonga
         }
       end
 
-      def select_convert_response(search_response)
+      def convert_response(search_response)
         select_responses = search_response.collect do |key, value|
           status_code = 0
 

  Modified: test/plugin/adapter/groonga/test_select.rb (+2 -2)
===================================================================
--- test/plugin/adapter/groonga/test_select.rb    2013-07-23 14:11:47 +0900 (885747d)
+++ test/plugin/adapter/groonga/test_select.rb    2013-07-23 14:14:11 +0900 (58580df)
@@ -50,7 +50,7 @@ class AdapterGroongaSelectTest < Test::Unit::TestCase
 
     private
     def convert(select_request)
-      @groonga_adapter.select_convert_request(select_request)
+      @groonga_adapter.convert_request(select_request)
     end
   end
 
@@ -83,7 +83,7 @@ class AdapterGroongaSelectTest < Test::Unit::TestCase
 
     private
     def convert(search_response)
-      @groonga_adapter.select_convert_response(search_response)
+      @groonga_adapter.convert_response(search_response)
     end
   end
 end
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index