[Groonga-commit] groonga/groonga at 961421f [master] clang: suppress a warning

Back to archive index

Kouhei Sutou null+****@clear*****
Mon Jun 10 16:49:18 JST 2013


Kouhei Sutou	2013-06-10 16:49:18 +0900 (Mon, 10 Jun 2013)

  New Revision: 961421fa4aaeec2f7adaaf9eedb7f5078a1c1b90
  https://github.com/groonga/groonga/commit/961421fa4aaeec2f7adaaf9eedb7f5078a1c1b90

  Message:
    clang: suppress a warning
    
        lib/db.c:7850:12: warning: assigning to
          'const unsigned char *' from 'const char *' converts between pointers to
          integer types with different sign [-Wpointer-sign]
            ap = grn_obj_get_value_(ctx, keys->key, b->id, &as);
               ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  Modified files:
    lib/db.c

  Modified: lib/db.c (+7 -4)
===================================================================
--- lib/db.c    2013-06-10 16:39:11 +0900 (78607c4)
+++ lib/db.c    2013-06-10 16:49:18 +0900 (3eaaacf)
@@ -7846,13 +7846,16 @@ compare_value(grn_ctx *ctx, sort_entry *a, sort_entry *b,
   const unsigned char *ap, *bp;
   for (i = 0; i < n_keys; i++, keys++) {
     if (i) {
+      const char *ap_raw, *bp_raw;
       if (keys->flags & GRN_TABLE_SORT_DESC) {
-        ap = grn_obj_get_value_(ctx, keys->key, b->id, &as);
-        bp = grn_obj_get_value_(ctx, keys->key, a->id, &bs);
+        ap_raw = grn_obj_get_value_(ctx, keys->key, b->id, &as);
+        bp_raw = grn_obj_get_value_(ctx, keys->key, a->id, &bs);
       } else {
-        ap = grn_obj_get_value_(ctx, keys->key, a->id, &as);
-        bp = grn_obj_get_value_(ctx, keys->key, b->id, &bs);
+        ap_raw = grn_obj_get_value_(ctx, keys->key, a->id, &as);
+        bp_raw = grn_obj_get_value_(ctx, keys->key, b->id, &bs);
       }
+      ap = (const unsigned char *)ap_raw;
+      bp = (const unsigned char *)bp_raw;
     } else {
       if (keys->flags & GRN_TABLE_SORT_DESC) {
         ap = b->value; as = b->size;
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index