[Groonga-commit] groonga/groonga at 5df7b51 [master] mruby: put an argument in a line

Back to archive index

YUKI Hiroshi yuki****@clear*****
Mon Oct 7 10:19:25 JST 2013


 >     mruby: put an argument in a line
 >
 >     Because other arugments are in each line.
 >

とのことですが、

 >     mrb_sis = mrb_funcall(mrb, mrb_obj_value(ctx->impl->mrb.module), 
"build", 4,

この部分も各行に分けた方がよいという事にならないでしょうか?


Kouhei Sutou wrote:
> Author
>     Kouhei Sutou <kou �� clear-code.com>
> Date
>     2013-10-06 10:58:11 +0900 (Sun, 06 Oct 2013)
> New Revision
>     5df7b514671c912fb0007c2b1740e08e8f295aea
>     <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea>
> Message
>
>     mruby: put an argument in a line
>
>     Because other arugments are in each line.
>
> Modified files
>
>       * lib/mrb/mrb_expr.c
>         <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#diff-0>
>
>    Modified: lib/mrb/mrb_expr.c (+2 -1)
> ===================================================================
>
> ...  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L358>
> 359  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L359>
> 360  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L360>
> 361  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L361>
> 362  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L362>
>
>
> 363  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L363>
> 364  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L364>
> 365  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0L365>
>
> 	
>
> ...  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R358>
> 359  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R359>
> 360  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R360>
> 361  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R361>
>
> 362  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R362>
> 363  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R363>
> 364  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R364>
> 365  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R365>
> 366  <https://github.com/groonga/groonga/commit/5df7b514671c912fb0007c2b1740e08e8f295aea#L0R366>
>
> 	
>
> @@ -359,7 +359,8 @@grn_mrb_scan_info_build(grn_ctx *ctx, grn_obj *expr, int *n,
>
>     mrb_sis = mrb_funcall(mrb, mrb_obj_value(ctx->impl->mrb.module), "build", 4,
>                           mrb_cptr_value(mrb, expr),
> -                        mrb_cptr_value(mrb, n), mrb_fixnum_value(op),
> +                        mrb_cptr_value(mrb, n),
> +                        mrb_fixnum_value(op),
>                           mrb_fixnum_value(size));
>     sis = mrb_cptr(mrb_sis);
>     return sis;
>
>
>
> _______________________________________________
> Groonga-commit mailing list
> Groonga-commit �� lists.sourceforge.jp
> http://lists.sourceforge.jp/mailman/listinfo/groonga-commit
>

-- 
結城 洋志 <YUKI Hiroshi>
E-mail: yuki �� clear-code.com

株式会社クリアコード
〒113-0033 東京都文京区本郷3-27-12
            本郷デントビル2階
TEL : 03-6231-7270
FAX : 03-6231-7271
WWW : http://www.clear-code.com/




More information about the Groonga-commit mailing list
Back to archive index