Kenji Okimoto
okimo****@clear*****
Tue Apr 8 17:55:59 JST 2014
(2014年04月08日 17:47), Kouhei Sutou wrote: > Author > Kouhei Sutou <kou �� clear-code.com> > Date > 2014-04-08 17:47:43 +0900 (Tue, 08 Apr 2014) > New Revision > 1b042c8d0fdf2c55f34a64a2ef64953cb7fef803 <https://github.com/droonga/fluent-plugin-droonga/commit/1b042c8d0fdf2c55f34a64a2ef64953cb7fef803> > Message > > Simplify > > "_records" in "RecordsFormatter#format_records" is verbosity. We can > know "RecordsFormatter#format" formats records. verbosity は名詞なのでこれだと "_records" そのものが verbosity だと読めます。 この場合は形容詞である verbose か redundant を使って "_records" in ... is verbose. とか "_records" in ... is redundant. とかするのがよいと思います。 > > Modified files > > * lib/droonga/searcher.rb <https://github.com/droonga/fluent-plugin-droonga/commit/1b042c8d0fdf2c55f34a64a2ef64953cb7fef803#diff-0> > > Modified: lib/droonga/searcher.rb (+2 -2) > =================================================================== > > > > @@ -526,7 +526,7 @@module Droonga > end > end > > - def format_records(output_target_attributes, records, output_limit, output_offset) > + def format(output_target_attributes, records, output_limit, output_offset) > cursor_options = { > :offset => output_offset, > :limit => output_limit > @@ -641,7 +641,7 @@module Droonga > else > formatter = SimpleRecordsFormatter.new > end > - formatter.format_records(output_target_attributes, @result.records, output_limit, output_offset) > + formatter.format(output_target_attributes, @result.records, output_limit, output_offset) > end > > def normalize_target_attributes(attributes, domain =****@resul*****) > > > > _______________________________________________ > Groonga-commit mailing list > Groonga-commit �� lists.sourceforge.jp > http://lists.sourceforge.jp/mailman/listinfo/groonga-commit > -- Kenji Okimoto <okimoto �� clear-code.com>
