[Groonga-commit] droonga/droonga-engine at f285fe7 [master] Break a long method

Back to archive index

Kouhei Sutou null+****@clear*****
Mon Apr 21 16:14:50 JST 2014


Kouhei Sutou	2014-04-21 16:14:50 +0900 (Mon, 21 Apr 2014)

  New Revision: f285fe77c6cddb0697918c9ed2f8bc2adfaaf32a
  https://github.com/droonga/droonga-engine/commit/f285fe77c6cddb0697918c9ed2f8bc2adfaaf32a

  Message:
    Break a long method

  Modified files:
    lib/droonga/engine/command/droonga_engine.rb

  Modified: lib/droonga/engine/command/droonga_engine.rb (+15 -3)
===================================================================
--- lib/droonga/engine/command/droonga_engine.rb    2014-04-21 16:08:35 +0900 (c6f7ac0)
+++ lib/droonga/engine/command/droonga_engine.rb    2014-04-21 16:14:50 +0900 (8f56703)
@@ -62,6 +62,16 @@ module Droonga
         private
         def parse_command_line_arguments!(command_line_arguments)
           parser = OptionParser.new
+          add_connection_options(parser)
+          add_log_options(parser)
+          parser.parse!(command_line_arguments)
+
+          ENV["DROOGNA_LOG_LEVEL"] = @log_level
+        end
+
+        def add_connection_options(parser)
+          parser.separator("")
+          parser.separator("Connection:")
           parser.on("--host=HOST",
                     "The host name of the Droonga engine",
                     "(#{@host})") do |host|
@@ -77,6 +87,11 @@ module Droonga
                     "(#{@tag})") do |tag|
             @tag = tag
           end
+        end
+
+        def add_log_options(parser)
+          parser.separator("")
+          parser.separator("Log:")
           levels = Logger::Level::LABELS
           levels_label = levels.join(",")
           parser.on("--log-level=LEVEL", levels,
@@ -85,9 +100,6 @@ module Droonga
                     "(#{@log_level})") do |level|
             @log_level = level
           end
-          parser.parse!(command_line_arguments)
-
-          ENV["DROOGNA_LOG_LEVEL"] = @log_level
         end
 
         def run_engine(loop)
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index