susumu.yata
null+****@clear*****
Fri Aug 1 10:09:14 JST 2014
susumu.yata 2014-08-01 10:09:14 +0900 (Fri, 01 Aug 2014) New Revision: 8db1eca7682a5a337d7534e266f8c62e771d3b1e https://github.com/groonga/grnxx/commit/8db1eca7682a5a337d7534e266f8c62e771d3b1e Message: Make Column::set_default_value() and unset() pure virtual. Modified files: include/grnxx/column.hpp lib/grnxx/column.cpp Modified: include/grnxx/column.hpp (+2 -2) =================================================================== --- include/grnxx/column.hpp 2014-08-01 10:05:48 +0900 (8594d63) +++ include/grnxx/column.hpp 2014-08-01 10:09:14 +0900 (568f747) @@ -180,10 +180,10 @@ class Column { // Returns true on success. // On failure, returns false and stores error information into "*error" if // "error" != nullptr. - virtual bool set_default_value(Error *error, Int row_id); + virtual bool set_default_value(Error *error, Int row_id) = 0; // Unset the value. - virtual void unset(Int row_id); + virtual void unset(Int row_id) = 0; friend class Table; }; Modified: lib/grnxx/column.cpp (+0 -10) =================================================================== --- lib/grnxx/column.cpp 2014-08-01 10:05:48 +0900 (093e2c9) +++ lib/grnxx/column.cpp 2014-08-01 10:09:14 +0900 (08f29c6) @@ -134,16 +134,6 @@ bool Column::set_initial_key(Error *error, Int row_id, const Datum &key) { return false; } -bool Column::set_default_value(Error *error, Int row_id) { - // TODO: This function should be a pure virtual function. - GRNXX_ERROR_SET(error, NOT_SUPPORTED_YET, "Not suported yet"); - return false; -} - -void Column::unset(Int row_id) { - // TODO: This function should be a pure virtual function. -} - // -- ColumnImpl<T> -- template <typename T> -------------- next part -------------- HTML����������������������������...Download