Takuro Ashie
ashie****@clear*****
Wed Aug 20 14:25:28 JST 2014
まったくわかってないのですが、コミットログにもマージのログにもPull Requestの メッセージにもほとんど何もかかれていなくて"catalog.rb"が追加された経緯がよく 分からない気がしたのですが、関係者なら（コードわかっている人なら）わかるもの なのでしょうか? ぱっと見、もう少し何かメッセージを書いた方がよい気がしました。 （何をどうすることを目的とするプラグインですとかなんとか） (2014年08月20日 13:19), long-long-float wrote: > > Author > long-long-float <niini****@yahoo*****> > Date > 2014-08-20 13:19:05 +0900 (Wed, 20 Aug 2014) > New Revision > f5126b10992861f209e81c7892d3765b3c41a08c > <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c> > Merge > > * Merged c84abd0: Merge pull request #8 from > long-long-float/add-catalog-plugin > > Message > Add "catalog.rb" > Added files > > * lib/droonga/plugins/catalog.rb > <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#diff-0> > > Added: lib/droonga/plugins/catalog.rb (+39 -0) 100644 > =================================================================== > ... <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0L-1> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ... <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R0> > 1 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R1> > 2 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R2> > 3 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R3> > 4 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R4> > 5 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R5> > 6 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R6> > 7 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R7> > 8 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R8> > 9 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R9> > 10 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R10> > 11 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R11> > 12 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R12> > 13 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R13> > 14 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R14> > 15 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R15> > 16 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R16> > 17 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R17> > 18 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R18> > 19 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R19> > 20 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R20> > 21 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R21> > 22 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R22> > 23 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R23> > 24 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R24> > 25 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R25> > 26 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R26> > 27 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R27> > 28 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R28> > 29 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R29> > 30 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R30> > 31 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R31> > 32 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R32> > 33 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R33> > 34 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R34> > 35 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R35> > 36 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R36> > 37 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R37> > 38 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R38> > 39 <https://github.com/droonga/droonga-engine/commit/f5126b10992861f209e81c7892d3765b3c41a08c#L0R39> > > @@ -0,0 +1,39 @@ > +# Copyright (C) 2013-2014 Droonga Project > +# > +# This library is free software; you can redistribute it and/or > +# modify it under the terms of the GNU Lesser General Public > +# License version 2.1 as published by the Free Software Foundation. > +# > +# This library is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +# Lesser General Public License for more details. > +# > +# You should have received a copy of the GNU Lesser General Public > +# License along with this library; if not, write to the Free Software > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + > +require "droonga/plugin" > + > +module Droonga > + module Plugins > + module Catalog > + extend Plugin > + register("catalog") > + > + class FetchHandler < Droonga::Handler > + action.synchronous = false > + > + def handle(message) > + JSON.parse(Path.catalog.read) > + end > + end > + > + define_single_step do |step| > + step.name = "catalog.fetch" > + step.handler = FetchHandler > + step.collector = Collectors::Or > + end > + end > + end > +end > > > > _______________________________________________ > Groonga-commit mailing list > Groon****@lists***** > http://lists.sourceforge.jp/mailman/listinfo/groonga-commit -------------- next part -------------- An HTML attachment was scrubbed...Download