[Groonga-commit] groonga/grnxx at 02cb499 [master] Update Expression to use typecast functions. (#105)

Back to archive index

susumu.yata null+****@clear*****
Tue Dec 16 10:42:19 JST 2014


susumu.yata	2014-11-13 11:39:03 +0900 (Thu, 13 Nov 2014)

  New Revision: 02cb499ba6f6de1616b0912aa0e7ea9061bcc196
  https://github.com/groonga/grnxx/commit/02cb499ba6f6de1616b0912aa0e7ea9061bcc196

  Message:
    Update Expression to use typecast functions. (#105)

  Modified files:
    lib/grnxx/impl/expression.cpp

  Modified: lib/grnxx/impl/expression.cpp (+3 -6)
===================================================================
--- lib/grnxx/impl/expression.cpp    2014-11-13 11:33:21 +0900 (4b31f67)
+++ lib/grnxx/impl/expression.cpp    2014-11-13 11:39:03 +0900 (915c53b)
@@ -684,8 +684,7 @@ void ToIntNode::evaluate(ArrayCRef<Record> records,
                          ArrayRef<Value> results) {
   fill_arg_values(records);
   for (size_t i = 0; i < records.size(); ++i) {
-    // TODO: Typecast inteface must be provided!
-    results[i] = Value(static_cast<int64_t>(arg_values_[i].value()));
+    results[i] = arg_values_[i].to_int();
   }
 }
 
@@ -707,8 +706,7 @@ class ToFloatNode : public UnaryNode<Float, Int> {
 void ToFloatNode::adjust(ArrayRef<Record> records) {
   fill_arg_values(records);
   for (size_t i = 0; i < records.size(); ++i) {
-    // TODO: Typecast inteface must be provided!
-    records[i].score = Value(static_cast<double>(arg_values_[i].value()));
+    records[i].score = arg_values_[i].to_float();
   }
 }
 
@@ -716,8 +714,7 @@ void ToFloatNode::evaluate(ArrayCRef<Record> records,
                            ArrayRef<Value> results) {
   fill_arg_values(records);
   for (size_t i = 0; i < records.size(); ++i) {
-    // TODO: Typecast inteface must be provided!
-    results[i] = Value(static_cast<double>(arg_values_[i].value()));
+    results[i] = arg_values_[i].to_float();
   }
 }
 
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index