[Groonga-commit] droonga/droonga-engine at 26e7181 [buffered-forward] Convert path to Pathname before handling

Back to archive index

Kouhei Sutou kou****@clear*****
Mon Dec 22 17:49:10 JST 2014


>        Pathname.glob("#{@data_directory}/*#{SUFFIX}").collect do |buffered_message_path|
> +        buffered_message_path = Pathname(buffered_message_path)

Pathname.globを使っているのですでにPathnameになっていません?

In <26e7181af6586fdba24a8710f399dbd520ffcb30 �� jenkins.clear-code.com>
  "[Groonga-commit] droonga/droonga-engine �� 26e7181 [buffered-forward] Convert path to Pathname before handling" on Mon, 22 Dec 2014 17:28:17 +0900,
  YUKI Hiroshi <null+groonga �� clear-code.com> wrote:

> YUKI Hiroshi	2014-12-22 17:28:17 +0900 (Mon, 22 Dec 2014)
> 
>   New Revision: 26e7181af6586fdba24a8710f399dbd520ffcb30
>   https://github.com/droonga/droonga-engine/commit/26e7181af6586fdba24a8710f399dbd520ffcb30
> 
>   Message:
>     Convert path to Pathname before handling
> 
>   Modified files:
>     lib/droonga/forward_buffer.rb
> 
>   Modified: lib/droonga/forward_buffer.rb (+1 -1)
> ===================================================================
> --- lib/droonga/forward_buffer.rb    2014-12-22 17:27:55 +0900 (372fd0d)
> +++ lib/droonga/forward_buffer.rb    2014-12-22 17:28:17 +0900 (e7f2fd6)
> @@ -57,6 +57,7 @@ module Droonga
>      def start_forward
>        logger.trace("start_forward: start")
>        Pathname.glob("#{@data_directory}/*#{SUFFIX}").collect do |buffered_message_path|
> +        buffered_message_path = Pathname(buffered_message_path)
>          output(buffered_message_path)
>        end
>        logger.trace("start_forward: done")
> @@ -68,7 +69,6 @@ module Droonga
>  
>      private
>      def output(buffered_message_path)
> -      buffered_message_path = Pathname(buffered_message_path)
>        time_stamp = buffered_message_path.basename(SUFFIX)
>        file_contents = buffered_message_path.read
>        @unpacker.feed(file_contents)




More information about the Groonga-commit mailing list
Back to archive index