[Groonga-commit] groonga/groonga at 7286bca [master] Stop to use world writable permission for newly created files

Back to archive index

Kouhei Sutou null+****@clear*****
Mon Dec 29 13:22:16 JST 2014


Kouhei Sutou	2014-12-29 13:22:16 +0900 (Mon, 29 Dec 2014)

  New Revision: 7286bca11d98b82d38ffc48bb0478bc21df2c845
  https://github.com/groonga/groonga/commit/7286bca11d98b82d38ffc48bb0478bc21df2c845

  Message:
    Stop to use world writable permission for newly created files
    
    If process don't have umask (= umask(0)) such as daemon mode
    groonga-httpd, newly created files have world writable permission. It's
    not good for security reason.
    
    It's backward incompatibility change.

  Modified files:
    lib/dat/file-impl.cpp
    lib/grn_io.h

  Modified: lib/dat/file-impl.cpp (+1 -1)
===================================================================
--- lib/dat/file-impl.cpp    2014-12-29 13:15:57 +0900 (8592d79)
+++ lib/dat/file-impl.cpp    2014-12-29 13:22:16 +0900 (3643a80)
@@ -39,7 +39,7 @@
 #ifdef WIN32
 # define GRN_IO_FILE_CREATE_MODE (GENERIC_READ | GENERIC_WRITE)
 #else /* WIN32 */
-# define GRN_IO_FILE_CREATE_MODE 0666
+# define GRN_IO_FILE_CREATE_MODE 0644
 #endif /* WIN32 */
 
 namespace grn {

  Modified: lib/grn_io.h (+1 -1)
===================================================================
--- lib/grn_io.h    2014-12-29 13:15:57 +0900 (5565bb0)
+++ lib/grn_io.h    2014-12-29 13:22:16 +0900 (6c19a5d)
@@ -41,7 +41,7 @@ extern "C" {
 #ifdef WIN32
 # define GRN_IO_FILE_CREATE_MODE (GENERIC_READ | GENERIC_WRITE)
 #else /* WIN32 */
-# define GRN_IO_FILE_CREATE_MODE 0666
+# define GRN_IO_FILE_CREATE_MODE 0644
 #endif /* WIN32 */
 
 typedef enum {
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index