Kouhei Sutou
kou****@clear*****
Mon Feb 3 12:50:22 JST 2014
> - planner.scatter > + planner.scatter(nil) > - planner.broadcast(:write => options[:write]) > + planner.broadcast(nil, :write => options[:write]) この、謎のnilって無くせないでしょうか？ 省略可能ならoptionsで指定するのでよさそうに思います。 In <0d15ee36f99896b2a2261e9f97ad835e3b974024 �� jenkins.clear-code.com> "[Groonga-commit] droonga/fluent-plugin-droonga �� 0d15ee3 [master] Broadcast messages correctly" on Mon, 03 Feb 2014 12:33:13 +0900, YUKI Hiroshi <null+groonga �� clear-code.com> wrote: > YUKI Hiroshi 2014-02-03 12:33:13 +0900 (Mon, 03 Feb 2014) > > New Revision: 0d15ee36f99896b2a2261e9f97ad835e3b974024 > https://github.com/droonga/fluent-plugin-droonga/commit/0d15ee36f99896b2a2261e9f97ad835e3b974024 > > Message: > Broadcast messages correctly > > Modified files: > lib/droonga/distributor_plugin.rb > > Modified: lib/droonga/distributor_plugin.rb (+2 -2) > =================================================================== > --- lib/droonga/distributor_plugin.rb 2014-02-03 12:26:56 +0900 (db6d94d) > +++ lib/droonga/distributor_plugin.rb 2014-02-03 12:33:13 +0900 (2ed9c15) > @@ -33,7 +33,7 @@ module Droonga > > def scatter(message, options={}) > planner = DistributedCommandPlanner.new(message) > - planner.scatter > + planner.scatter(nil) > planner.key = options[:key] > planner.reduce(options[:reduce]) > planner.plan > @@ -42,7 +42,7 @@ module Droonga > > def broadcast(message, options={}) > planner = DistributedCommandPlanner.new(message) > - planner.broadcast(:write => options[:write]) > + planner.broadcast(nil, :write => options[:write]) > planner.reduce(options[:reduce]) > planner.plan > distribute(planner.messages)
