[Groonga-commit] droonga/grn2drn at 5487505 [master] Use more meaningful name

Back to archive index

Kouhei Sutou null+****@clear*****
Sun Feb 9 10:42:21 JST 2014


Kouhei Sutou	2014-02-09 10:42:21 +0900 (Sun, 09 Feb 2014)

  New Revision: 54875051000d07486cc4a8d719ed598886c6fdf0
  https://github.com/droonga/grn2drn/commit/54875051000d07486cc4a8d719ed598886c6fdf0

  Message:
    Use more meaningful name
    
    :id isn't used as ID. It is used as a part of ID.

  Modified files:
    lib/grn2drn/converter.rb
    test/test-converter.rb

  Modified: lib/grn2drn/converter.rb (+3 -3)
===================================================================
--- lib/grn2drn/converter.rb    2014-02-09 10:38:21 +0900 (bb95360)
+++ lib/grn2drn/converter.rb    2014-02-09 10:42:21 +0900 (16b179b)
@@ -70,11 +70,11 @@ module Grn2Drn
 
     private
     def create_message(type, body)
-      id = @options[:id]
-      if id.nil?
+      base_id = @options[:base_id]
+      if base_id.nil?
         id = new_unique_id
       else
-        id = "#{id}:#{@count}"
+        id = "#{base_id}:#{@count}"
         @count += 1
       end
 

  Modified: test/test-converter.rb (+1 -1)
===================================================================
--- test/test-converter.rb    2014-02-09 10:38:21 +0900 (f37ba31)
+++ test/test-converter.rb    2014-02-09 10:42:21 +0900 (265ea0d)
@@ -19,7 +19,7 @@ class ConverterTest < Test::Unit::TestCase
   private
   def converter
     options = {
-      :id => "test",
+      :base_id => "test",
       :date => date,
       :reply_to => reply_to,
       :dataset => dataset,
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index