[Groonga-commit] droonga/fluent-plugin-droonga at 6562eaf [master] Report errors for missing required parameters

Back to archive index

YUKI Hiroshi null+****@clear*****
Wed Feb 12 18:43:56 JST 2014


YUKI Hiroshi	2014-02-12 18:43:56 +0900 (Wed, 12 Feb 2014)

  New Revision: 6562eafcbef85ecfd8c8d2645be775e2ea2a18b6
  https://github.com/droonga/fluent-plugin-droonga/commit/6562eafcbef85ecfd8c8d2645be775e2ea2a18b6

  Message:
    Report errors for missing required parameters

  Modified files:
    lib/droonga/catalog/base.rb

  Modified: lib/droonga/catalog/base.rb (+4 -0)
===================================================================
--- lib/droonga/catalog/base.rb    2014-02-12 18:40:27 +0900 (89cf87c)
+++ lib/droonga/catalog/base.rb    2014-02-12 18:43:56 +0900 (5a493cb)
@@ -184,6 +184,7 @@ module Droonga
       end
 
       def validate_valid_datetime(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(String, value, name)
         begin
           Time.parse(value)
@@ -193,6 +194,7 @@ module Droonga
       end
 
       def validate_positive_numeric_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Numeric, value, name)
         if value < 0
           raise NegativeNumber.new(name, value, @path)
@@ -200,6 +202,7 @@ module Droonga
       end
 
       def validate_positive_integer_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Integer, value, name)
         if value < 0
           raise NegativeNumber.new(name, value, @path)
@@ -207,6 +210,7 @@ module Droonga
       end
 
       def validate_one_or_larger_integer_parameter(value, name)
+        raise MissingRequiredParameter.new(name, @path) unless value
         validate_parameter_type(Integer, value, name)
         if value < 1
           raise SmallerThanOne.new(name, value, @path)
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index