[Groonga-commit] droonga/fluent-plugin-droonga at 2a969a7 [master] Remove needless freeze

Back to archive index

Kouhei Sutou null+****@clear*****
Wed Jan 29 13:54:39 JST 2014


Kouhei Sutou	2014-01-29 13:54:39 +0900 (Wed, 29 Jan 2014)

  New Revision: 2a969a747b2f09ceb2238ffc6bd074db26114da4
  https://github.com/droonga/fluent-plugin-droonga/commit/2a969a747b2f09ceb2238ffc6bd074db26114da4

  Message:
    Remove needless freeze
    
    Ruby 2.2.0 will introduce a freeze optimization but we don't expect
    the effect. We should prefer to simpler code. Simpler code will
    improve maintainability.

  Modified files:
    lib/droonga/plugin/collector/basic.rb
    lib/droonga/plugin/distributor/distributed_search_planner.rb
    lib/droonga/replier.rb
    lib/droonga/searcher.rb
    lib/groonga_command_converter.rb

  Modified: lib/droonga/plugin/collector/basic.rb (+1 -1)
===================================================================
--- lib/droonga/plugin/collector/basic.rb    2014-01-29 13:16:36 +0900 (1fbe13c)
+++ lib/droonga/plugin/collector/basic.rb    2014-01-29 13:54:39 +0900 (8758f04)
@@ -21,7 +21,7 @@ module Droonga
   class BasicCollector < Droonga::CollectorPlugin
     repository.register("basic", self)
 
-    UNLIMITED = -1.freeze
+    UNLIMITED = -1
 
     command :collector_gather
     def collector_gather(result)

  Modified: lib/droonga/plugin/distributor/distributed_search_planner.rb (+2 -2)
===================================================================
--- lib/droonga/plugin/distributor/distributed_search_planner.rb    2014-01-29 13:16:36 +0900 (878d3ea)
+++ lib/droonga/plugin/distributor/distributed_search_planner.rb    2014-01-29 13:54:39 +0900 (0d66b45)
@@ -361,8 +361,8 @@ module Droonga
         sort_attributes
       end
 
-      ASCENDING_OPERATOR = "<".freeze
-      DESCENDING_OPERATOR = ">".freeze
+      ASCENDING_OPERATOR = "<"
+      DESCENDING_OPERATOR = ">"
 
       def build_records_reducer
         attributes = @output["attributes"]

  Modified: lib/droonga/replier.rb (+1 -1)
===================================================================
--- lib/droonga/replier.rb    2014-01-29 13:16:36 +0900 (7b8997b)
+++ lib/droonga/replier.rb    2014-01-29 13:54:39 +0900 (4ce77a7)
@@ -15,7 +15,7 @@
 
 module Droonga
   class Replier
-    STATUS_OK = 200.freeze
+    STATUS_OK = 200
 
     def initialize(forwarder)
       @forwarder = forwarder

  Modified: lib/droonga/searcher.rb (+1 -1)
===================================================================
--- lib/droonga/searcher.rb    2014-01-29 13:16:36 +0900 (e63d8b9)
+++ lib/droonga/searcher.rb    2014-01-29 13:54:39 +0900 (98eb50b)
@@ -190,7 +190,7 @@ module Droonga
         "||" => Groonga::Operator::OR,
         "&&" => Groonga::Operator::AND,
         "-"  => Groonga::Operator::AND_NOT,
-      }.freeze
+      }
 
       class << self
         def search(search_request)

  Modified: lib/groonga_command_converter.rb (+1 -1)
===================================================================
--- lib/groonga_command_converter.rb    2014-01-29 13:16:36 +0900 (2082039)
+++ lib/groonga_command_converter.rb    2014-01-29 13:54:39 +0900 (fdf832a)
@@ -21,7 +21,7 @@ require "time"
 
 module Droonga
   class GroongaCommandConverter
-    STATUS_OK = 200.freeze
+    STATUS_OK = 200
 
     def initialize(options={})
       @options = options
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index