[Groonga-commit] groonga/heroku-buildpack-groonga at ad12a84 [master] Use File.open instead of Kernel#open

Back to archive index

Kouhei Sutou null+****@clear*****
Tue Jul 8 09:57:47 JST 2014


Kouhei Sutou	2014-07-08 09:57:47 +0900 (Tue, 08 Jul 2014)

  New Revision: ad12a84d9803f0b3c8e4e03193133b26917dea7f
  https://github.com/groonga/heroku-buildpack-groonga/commit/ad12a84d9803f0b3c8e4e03193133b26917dea7f

  Message:
    Use File.open instead of Kernel#open
    
    "File.open" describes that the code only opens local file. It doesn't
    open external file over HTTP. open-uri extends open to support opening
    external files.

  Modified files:
    bin/compile

  Modified: bin/compile (+3 -3)
===================================================================
--- bin/compile    2014-07-07 23:53:05 +0900 (3ae2c5d)
+++ bin/compile    2014-07-08 09:57:47 +0900 (b804d71)
@@ -106,10 +106,10 @@ Dir.chdir(build_dir) do
   end
 
   puts("-----> Setting environment variables")
-  open("#{env_dir}/LD_LIBRARY_PATH", "w") do |env_file|
+  File.open("#{env_dir}/LD_LIBRARY_PATH", "w") do |env_file|
     env_file.print(ENV["LD_LIBRARY_PATH"])
   end
-  open("#{env_dir}/PKG_CONFIG_PATH", "w") do |env_file|
+  File.open("#{env_dir}/PKG_CONFIG_PATH", "w") do |env_file|
     pkg_config_paths = [
       "#{lib_dir}/pkgconfig",
       environment_variables["PKG_CONFIG_PATH"],
@@ -121,7 +121,7 @@ Dir.chdir(build_dir) do
   app_dir = ENV["HOME"]
   profile_dir="#{build_dir}/.profile.d"
   FileUtils.mkdir_p(profile_dir)
-  open("#{profile_dir}/groonga.sh", "w") do |env_file|
+  File.open("#{profile_dir}/groonga.sh", "w") do |env_file|
     ld_library_paths = ["#{app_dir}/#{prefix}/lib"] + base_ld_library_paths
     ld_library_path = build_path_environment_value(ld_library_paths)
     env_file.puts("export LD_LIBRARY_PATH=#{ld_library_path}")
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index