Kouhei Sutou
null+****@clear*****
Sat Jun 28 23:34:48 JST 2014
Kouhei Sutou 2014-06-28 23:34:48 +0900 (Sat, 28 Jun 2014) New Revision: 4f82db93f399fbe1cebae91acb71392316d0d075 https://github.com/droonga/droonga-engine/commit/4f82db93f399fbe1cebae91acb71392316d0d075 Message: Add TODO comments Modified files: lib/droonga/serf.rb Modified: lib/droonga/serf.rb (+6 -0) =================================================================== --- lib/droonga/serf.rb 2014-06-28 23:20:31 +0900 (3525da1) +++ lib/droonga/serf.rb 2014-06-28 23:34:48 +0900 (37f9a7d) @@ -69,6 +69,8 @@ module Droonga include Loggable def initialize(loop, name) + # TODO: Don't allow nil for loop. It reduces nil checks and + # simplifies source code. @loop = loop @name = name @agent = nil @@ -254,6 +256,8 @@ module Droonga @output_io.on_read do |data| on_read_output.call(data) end + # TODO: Don't allow nil for loop. It reduces nil checks and + # simplifies source code. @loop.attach(@output_io) if @loop error_line_buffer = LineBuffer.new @@ -264,6 +268,8 @@ module Droonga @error_io.on_read do |data| on_read_error.call(data) end + # TODO: Don't allow nil for loop. It reduces nil checks and + # simplifies source code. @loop.attach(@error_io) if @loop result -------------- next part -------------- HTML����������������������������...Download