Kouhei Sutou
null+****@clear*****
Sat Jun 28 23:37:15 JST 2014
Kouhei Sutou 2014-06-28 23:37:15 +0900 (Sat, 28 Jun 2014) New Revision: 7ac975fa0e216f9abdfebeb3507b84eb9fd37086 https://github.com/droonga/droonga-engine/commit/7ac975fa0e216f9abdfebeb3507b84eb9fd37086 Message: Add a TODO comment Modified files: bin/droonga-engine-catalog-modify Modified: bin/droonga-engine-catalog-modify (+3 -0) =================================================================== --- bin/droonga-engine-catalog-modify 2014-06-28 23:34:48 +0900 (f7fdf4a) +++ bin/droonga-engine-catalog-modify 2014-06-28 23:37:15 +0900 (376fbd2) @@ -90,6 +90,9 @@ end source_catalog = load_source(options.source_path) source_params = generator.catalog_to_params(source_catalog) +# TODO: Reduce too much class method calls. It is not object oriented +# programming style. It just uses class as a namespace. It is +# procedure based programming style. modified_params = Droonga::CatalogGenerator.update_params(source_params, datasets) modified_catalog = Droonga::CatalogGenerator.generate(modified_params) -------------- next part -------------- HTML����������������������������...Download