[Groonga-commit] droonga/express-droonga at bebeb5c [master] Don't raise "missing server" error if there is no Socket.IO command is registered.

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Mar 28 15:25:07 JST 2014


YUKI Hiroshi	2014-03-28 15:25:07 +0900 (Fri, 28 Mar 2014)

  New Revision: bebeb5cca959bf034cfc1b43e0983e743bc8ea9b
  https://github.com/droonga/express-droonga/commit/bebeb5cca959bf034cfc1b43e0983e743bc8ea9b

  Message:
    Don't raise "missing server" error if there is no Socket.IO command is registered.

  Modified files:
    lib/adapter/socket.io.js

  Modified: lib/adapter/socket.io.js (+3 -3)
===================================================================
--- lib/adapter/socket.io.js    2014-03-28 15:06:48 +0900 (eaecf59)
+++ lib/adapter/socket.io.js    2014-03-28 15:25:07 +0900 (d151631)
@@ -31,9 +31,6 @@ exports.register = function(application, server, params) {
   if (!connection)
     throw new Error('Connection to the backend is required!');
 
-  if (!server)
-    throw new Error('A server instance is required!');
-
   function createClientMessageHandler(commandName, commandDefinition, socket, handlerOptions) {
     handlerOptions = handlerOptions || {};
 
@@ -159,6 +156,9 @@ exports.register = function(application, server, params) {
                                                   definition));
   });
 
+  if (registeredCommands.length > 0 && !server)
+    throw new Error('A server instance is required for Socket.IO commands!');
+
   var io = socketIo.listen(server);
 
   // share session information with HTTP connections
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-commit mailing list
Back to archive index